Groups > linux.kernel > #1611915

Re: [PATCH v2 2/7] dt-bindings: pinctrl: Add RZ/A1 bindings doc

From	Linus Walleij <linus.walleij@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 2/7] dt-bindings: pinctrl: Add RZ/A1 bindings doc
Date	2017-03-29 15:10 +0200
Message-ID	<tqlwl-7hB-11@gated-at.bofh.it> (permalink)
References	(5 earlier) <tq0Bz-A0-11@gated-at.bofh.it> <tqbGF-lQ-3@gated-at.bofh.it> <tqgmZ-3Eh-1@gated-at.bofh.it> <tqiRQ-5sN-17@gated-at.bofh.it> <tqjXA-67g-37@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Mar 29, 2017 at 1:20 PM, Geert Uytterhoeven
<geert@linux-m68k.org> wrote:

>> I do not understand the notion of "flags" here. I hope that is not referring
>
> Flags refers to BI_DIR, SWIO_IN, and SWIO_OUT, from
> https://patchwork.kernel.org/patch/9643047/

Aha I will go in and review that closer because it doesn't seem right.

Sorry for missing it.

>> i2c1_pins_a: i2c1@0 {
>>     pins {
>>         pinmux = <MT8135_PIN_195_SDA1__FUNC_SDA1>,
>>                         <MT8135_PIN_196_SCL1__FUNC_SCL1>;
>
> If we follow this example, then we can list all combinations in
> include/dt-bindings/pinctrl/r7s72100-pinctrl.h, instead of creating the value
> by combining the bits using a macro where we need it in the DTS.
>
> It's gonna be a long list, though...

Size is not the issue, readability is the issue. I don't see why you would
need to list "all combinations" since the trees go through the C preprocessor
so you can use macros and bit | OR to build them?

Yours,
Linus Walleij

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2 2/7] dt-bindings: pinctrl: Add RZ/A1 bindings doc Linus Walleij <linus.walleij@linaro.org> - 2017-03-28 11:50 +0200
  Re: [PATCH v2 2/7] dt-bindings: pinctrl: Add RZ/A1 bindings doc jacopo@jmondi.org - 2017-03-28 16:50 +0200
    Re: [PATCH v2 2/7] dt-bindings: pinctrl: Add RZ/A1 bindings doc Linus Walleij <linus.walleij@linaro.org> - 2017-03-29 04:40 +0200
      Re: [PATCH v2 2/7] dt-bindings: pinctrl: Add RZ/A1 bindings doc Geert Uytterhoeven <geert@linux-m68k.org> - 2017-03-29 09:40 +0200
        Re: [PATCH v2 2/7] dt-bindings: pinctrl: Add RZ/A1 bindings doc Linus Walleij <linus.walleij@linaro.org> - 2017-03-29 12:20 +0200
          Re: [PATCH v2 2/7] dt-bindings: pinctrl: Add RZ/A1 bindings doc Geert Uytterhoeven <geert@linux-m68k.org> - 2017-03-29 13:30 +0200
            Re: [PATCH v2 2/7] dt-bindings: pinctrl: Add RZ/A1 bindings doc jacopo <jacopo@jmondi.org> - 2017-03-29 14:10 +0200
              RE: [PATCH v2 2/7] dt-bindings: pinctrl: Add RZ/A1 bindings doc Chris Brandt <Chris.Brandt@renesas.com> - 2017-03-29 14:40 +0200
                Re: [PATCH v2 2/7] dt-bindings: pinctrl: Add RZ/A1 bindings doc Linus Walleij <linus.walleij@linaro.org> - 2017-03-29 15:20 +0200
                RE: [PATCH v2 2/7] dt-bindings: pinctrl: Add RZ/A1 bindings doc Chris Brandt <Chris.Brandt@renesas.com> - 2017-03-29 16:20 +0200
            Re: [PATCH v2 2/7] dt-bindings: pinctrl: Add RZ/A1 bindings doc Linus Walleij <linus.walleij@linaro.org> - 2017-03-29 15:10 +0200

csiph-web