Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1611947
| From | Christian König <deathsimple@vodafone.de> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] Fix IB va_start+ib_bytes range check on 32Bit systems |
| Date | 2017-03-29 15:30 +0200 |
| Message-ID | <tqlPJ-7sg-31@gated-at.bofh.it> (permalink) |
| References | <tqi5s-4RU-23@gated-at.bofh.it> <tqi5s-4RU-21@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Am 29.03.2017 um 11:18 schrieb Jan Burgmeier:
> Signed-off-by: Jan Burgmeier <jan.burgmeier@unicon-software.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
> index 99424cb8020b..583d22974e14 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
> @@ -908,6 +908,7 @@ static int amdgpu_cs_ib_fill(struct amdgpu_device *adev,
> struct amdgpu_bo *aobj = NULL;
> uint64_t offset;
> uint8_t *kptr;
> + uint64_t it_last;
>
> m = amdgpu_cs_find_mapping(parser, chunk_ib->va_start,
> &aobj);
> @@ -916,8 +917,9 @@ static int amdgpu_cs_ib_fill(struct amdgpu_device *adev,
> return -EINVAL;
> }
>
> + it_last = m->it.last;
> if ((chunk_ib->va_start + chunk_ib->ib_bytes) >
> - (m->it.last + 1) * AMDGPU_GPU_PAGE_SIZE) {
> + (it_last + 1) * AMDGPU_GPU_PAGE_SIZE) {
Nice catch, but just adding a u64 case should do here as well. E.g:
if ((chunk_ib->va_start + chunk_ib->ib_bytes) >
(u64)(m->it.last + 1) * AMDGPU_GPU_PAGE_SIZE) {
With that fixed the patch is Reviewed-by: Christian König
<christian.koenig@amd.com>.
Regards,
Christian.
> DRM_ERROR("IB va_start+ib_bytes is invalid\n");
> return -EINVAL;
> }
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] Fix IB va_start+ib_bytes range check on 32Bit systems Jan Burgmeier <jan.burgmeier@unicon-software.com> - 2017-03-29 11:30 +0200
Re: [PATCH] Fix IB va_start+ib_bytes range check on 32Bit systems Christian König <deathsimple@vodafone.de> - 2017-03-29 15:30 +0200
Re: [PATCH] Fix IB va_start+ib_bytes range check on 32Bit systems Michel Dänzer <michel@daenzer.net> - 2017-03-29 17:00 +0200
Re: [PATCH] Fix IB va_start+ib_bytes range check on 32Bit systems Christian König <deathsimple@vodafone.de> - 2017-03-29 17:20 +0200
Re: [PATCH] Fix IB va_start+ib_bytes range check on 32Bit systems Michel Dänzer <michel@daenzer.net> - 2017-03-30 03:50 +0200
Re: [PATCH] Fix IB va_start+ib_bytes range check on 32Bit systems Christian König <deathsimple@vodafone.de> - 2017-03-30 10:40 +0200
csiph-web