Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1611943

Re: [PATCH 4/8] asm-generic: add atomic-instrumented.h

Show all headers | View raw

On Tue, Mar 28, 2017 at 02:35:13PM -0700, Matthew Wilcox wrote:
> On Tue, Mar 28, 2017 at 06:15:41PM +0200, Dmitry Vyukov wrote:
> > The new header allows to wrap per-arch atomic operations
> > and add common functionality to all of them.
> 
> Why a new header instead of putting this in linux/atomic.h?

The idea was that doing it this way allowed architectures to switch over
to the arch_* naming without a flag day. Currently this only matters for
KASAN, which is only supported by a couple of architectures (arm64,
x86).

I seem to recall that there was an issue that prevented us from solving
this with ifdeffery early in linux/atomic.h like:

#ifdef arch_op
#define op(...) ({ 		\
	kasna_whatever(...)	\
	arch_op(...)		\
})
#endif

... but I can't recall specifically what it was.

Thanks,
Mark.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 4/8] asm-generic: add atomic-instrumented.h Dmitry Vyukov <dvyukov@google.com> - 2017-03-28 18:20 +0200
  Re: [PATCH 4/8] asm-generic: add atomic-instrumented.h Matthew Wilcox <willy@infradead.org> - 2017-03-28 23:40 +0200
    Re: [PATCH 4/8] asm-generic: add atomic-instrumented.h Dmitry Vyukov <dvyukov@google.com> - 2017-03-29 10:30 +0200
    Re: [PATCH 4/8] asm-generic: add atomic-instrumented.h Mark Rutland <mark.rutland@arm.com> - 2017-03-29 15:30 +0200
  Re: [PATCH 4/8] asm-generic: add atomic-instrumented.h Mark Rutland <mark.rutland@arm.com> - 2017-03-29 19:20 +0200
    Re: [PATCH 4/8] asm-generic: add atomic-instrumented.h Ingo Molnar <mingo@kernel.org> - 2017-03-30 08:50 +0200
      Re: [PATCH 4/8] asm-generic: add atomic-instrumented.h Mark Rutland <mark.rutland@arm.com> - 2017-03-30 12:50 +0200

csiph-web