Re: [PATCH RFC] [media] m5mols: add missing dependency on VIDEO_IR_I2C

From	Sylwester Nawrocki <s.nawrocki@samsung.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH RFC] [media] m5mols: add missing dependency on VIDEO_IR_I2C
Date	2017-03-29 12:00 +0200
Message-ID	<tqiyu-55o-25@gated-at.bofh.it> (permalink)
References	<sNO8p-5Hf-1@gated-at.bofh.it> <tqiyu-55o-27@gated-at.bofh.it> <sNO8p-5Hf-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 12/13/2016 06:44 AM, Nicholas Mc Guire wrote:
> The Depends on: tag in Kconfig for CONFIG_VIDEO_M5MOLS does not list
> VIDEO_IR_I2C so Kconfig displays the dependencies needed so the M-5MOLS
> driver can not be found.
>
> Fixes: commit cb7a01ac324b ("[media] move i2c files into drivers/media/i2c")
> Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
> ---
>
> searching for VIDEO_M5MOLS in menuconfig currently shows the following
> dependencies
>  Depends on: MEDIA_SUPPORT [=m] && I2C [=y] && VIDEO_V4L2 [=m] && \
>              VIDEO_V4L2_SUBDEV_API [=y] && MEDIA_CAMERA_SUPPORT [=y]
> but as the default settings include MEDIA_SUBDRV_AUTOSELECT=y the
> "I2C module for IR" submenu (CONFIG_VIDEO_IR_I2C) is not displayed
> adding the VIDEO_IR_I2C to the dependency list makes this clear

>  drivers/media/i2c/m5mols/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/i2c/m5mols/Kconfig b/drivers/media/i2c/m5mols/Kconfig
> index dc8c250..6847a1b 100644
> --- a/drivers/media/i2c/m5mols/Kconfig
> +++ b/drivers/media/i2c/m5mols/Kconfig
> @@ -1,6 +1,6 @@
>  config VIDEO_M5MOLS
>  	tristate "Fujitsu M-5MOLS 8MP sensor support"
> -	depends on I2C && VIDEO_V4L2 && VIDEO_V4L2_SUBDEV_API
> +	depends on I2C && VIDEO_IR_I2C && VIDEO_V4L2 && VIDEO_V4L2_SUBDEV_API

There should be no need to enable the "I2C module for IR" to use m5mols driver, 
so the bug fix needs to be somewhere else.

-- 
Thanks,
Sylwester

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH RFC] [media] m5mols: add missing dependency on  VIDEO_IR_I2C Sylwester Nawrocki <s.nawrocki@samsung.com> - 2017-03-29 12:00 +0200
  Re: [PATCH RFC] [media] m5mols: add missing dependency on  VIDEO_IR_I2C Nicholas Mc Guire <der.herr@hofr.at> - 2017-03-29 12:50 +0200

csiph-web