Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1611621

Re: [RFC]mm/zsmalloc,: trigger BUG_ON in function zs_map_object.

From Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Newsgroups linux.kernel
Subject Re: [RFC]mm/zsmalloc,: trigger BUG_ON in function zs_map_object.
Date 2017-03-29 08:50 +0200
Message-ID <tqfAC-37f-5@gated-at.bofh.it> (permalink)
References <tpTJL-4au-9@gated-at.bofh.it> <tq9ES-7iH-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On (03/29/17 09:20), Minchan Kim wrote:
> Hello,
> 
> On Tue, Mar 28, 2017 at 03:20:22PM +0800, Yisheng Xie wrote:
> > Hi, all,
> > 
> > We had backport the no-lru migration to linux-4.1, meanwhile change the
> > ZS_MAX_ZSPAGE_ORDER to 3. Then we met a BUG_ON(!page[1]).
> 
> Hmm, I don't know how you backported.
> 
> There isn't any problem with default ZS_MAX_ZSPAGE_ORDER. Right?
> So, it happens only if you changed it to 3?

I agree with Minchan. too much things could have gone wrong during the backport.

> Could you tell me what is your base kernel? and what zram/zsmalloc
> version(ie, from what kernel version) you backported to your
> base kernel?

agree again.



Yisheng, do you have this commit applied?

commit c102f07ca0b04f2cb49cfc161c83f6239d17f491
Author: Junil Lee <junil0814.lee@lge.com>
Date:   Wed Jan 20 14:58:18 2016 -0800

    zsmalloc: fix migrate_zspage-zs_free race condition


	-ss

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[RFC]mm/zsmalloc,: trigger BUG_ON in function zs_map_object. Yisheng Xie <xieyisheng1@huawei.com> - 2017-03-28 09:30 +0200
  Re: [RFC]mm/zsmalloc,: trigger BUG_ON in function zs_map_object. Minchan Kim <minchan@kernel.org> - 2017-03-29 02:30 +0200
    Re: [RFC]mm/zsmalloc,: trigger BUG_ON in function zs_map_object. Sergey Senozhatsky <sergey.senozhatsky@gmail.com> - 2017-03-29 08:50 +0200
      Re: [RFC]mm/zsmalloc,: trigger BUG_ON in function zs_map_object. Yisheng Xie <xieyisheng1@huawei.com> - 2017-03-29 10:00 +0200
    Re: [RFC]mm/zsmalloc,: trigger BUG_ON in function zs_map_object. Yisheng Xie <xieyisheng1@huawei.com> - 2017-03-29 10:00 +0200

csiph-web