Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1611582

[RFC PATCH tip/master 1/3] trace: kprobes: Show sum of probe/retprobe nmissed count

From Masami Hiramatsu <mhiramat@kernel.org>
Newsgroups linux.kernel
Subject [RFC PATCH tip/master 1/3] trace: kprobes: Show sum of probe/retprobe nmissed count
Date 2017-03-29 07:30 +0200
Message-ID <tqelb-2ha-1@gated-at.bofh.it> (permalink)
References <tqelb-2ha-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Show sum of probe and retprobe nmissed count in
kprobe_profile, since retprobe can be missed even
if the kprobe itself succeeeded.
This explains user why their return probe didn't hit
sometimes.

Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>
---
 kernel/trace/trace_kprobe.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/trace/trace_kprobe.c b/kernel/trace/trace_kprobe.c
index 013f4e7..bbdc3de 100644
--- a/kernel/trace/trace_kprobe.c
+++ b/kernel/trace/trace_kprobe.c
@@ -896,7 +896,7 @@ static int probes_profile_seq_show(struct seq_file *m, void *v)
 	seq_printf(m, "  %-44s %15lu %15lu\n",
 		   trace_event_name(&tk->tp.call),
 		   trace_kprobe_nhit(tk),
-		   tk->rp.kp.nmissed);
+		   tk->rp.kp.nmissed + tk->rp.nmissed);
 
 	return 0;
 }

Back to linux.kernel | Previous | NextNext in thread | Find similar | Unroll thread


Thread

[RFC PATCH tip/master 1/3] trace: kprobes: Show sum of probe/retprobe nmissed count Masami Hiramatsu <mhiramat@kernel.org> - 2017-03-29 07:30 +0200
  Re: [RFC PATCH tip/master 1/3] trace: kprobes: Show sum of  probe/retprobe nmissed count Alban Crequy <alban@kinvolk.io> - 2017-03-31 11:50 +0200

csiph-web