Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1613440

Re: [PATCH net v2] openvswitch: Fix ovs_flow_key_update()

From Jiri Benc <jbenc@redhat.com>
Newsgroups linux.kernel
Subject Re: [PATCH net v2] openvswitch: Fix ovs_flow_key_update()
Date 2017-03-30 22:10 +0200
Message-ID <tqOyn-36A-45@gated-at.bofh.it> (permalink)
References <tqOf2-2K2-59@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Thu, 30 Mar 2017 12:36:03 -0700, Yi-Hung Wei wrote:
> ovs_flow_key_update() is called when the flow key is invalid, and it is
> used to update and revalidate the flow key. Commit 329f45bc4f19
> ("openvswitch: add mac_proto field to the flow key") introduces mac_proto
> field to flow key and use it to determine whether the flow key is valid.
> However, the commit does not update the code path in ovs_flow_key_update()
> to revalidate the flow key which may cause BUG_ON() on execute_recirc().
> This patch addresses the aforementioned issue.
> 
> Fixes: 329f45bc4f19 ("openvswitch: add mac_proto field to the flow key")
> Signed-off-by: Yi-Hung Wei <yihung.wei@gmail.com>

Acked-by: Jiri Benc <jbenc@redhat.com>

Thanks!

 Jiri

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH net v2] openvswitch: Fix ovs_flow_key_update() Yi-Hung Wei <yihung.wei@gmail.com> - 2017-03-30 21:50 +0200
  Re: [PATCH net v2] openvswitch: Fix ovs_flow_key_update() Jiri Benc <jbenc@redhat.com> - 2017-03-30 22:10 +0200
  Re: [PATCH net v2] openvswitch: Fix ovs_flow_key_update() David Miller <davem@davemloft.net> - 2017-04-01 21:20 +0200

csiph-web