Re: [PATCH] virtio_net: fix mergeable bufs error handling

From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH] virtio_net: fix mergeable bufs error handling
Date	2017-03-30 20:00 +0200
Message-ID	<tqMwx-1vj-11@gated-at.bofh.it> (permalink)
References	<tql3j-6Rq-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: "Michael S. Tsirkin" <mst@redhat.com>
Date: Wed, 29 Mar 2017 15:37:37 +0300

> @@ -570,7 +570,7 @@ static struct sk_buff *receive_mergeable(struct net_device *dev,
>  	u16 num_buf;
>  	struct page *page;
>  	int offset;
> -	struct sk_buff *head_skb, *curr_skb;
> +	struct sk_buff *head_skb = NULL, *curr_skb;
>  	struct bpf_prog *xdp_prog;
>  	unsigned int truesize;
>  

Like Jason, I see the very next line is:

	head_skb = NULL;

so I don't think this is necessary.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] virtio_net: fix mergeable bufs error handling "Michael S. Tsirkin" <mst@redhat.com> - 2017-03-29 14:40 +0200
  Re: [PATCH] virtio_net: fix mergeable bufs error handling Jason Wang <jasowang@redhat.com> - 2017-03-30 06:00 +0200
  Re: [PATCH] virtio_net: fix mergeable bufs error handling David Miller <davem@davemloft.net> - 2017-03-30 20:00 +0200

csiph-web