Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1613307
| From | Matthew Wilcox <willy@infradead.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 4/4] mm/vmalloc: remove vfree_atomic() |
| Date | 2017-03-30 19:20 +0200 |
| Message-ID | <tqLTQ-1a6-23@gated-at.bofh.it> (permalink) |
| References | <tqLTQ-1a6-25@gated-at.bofh.it> <tqLTQ-1a6-27@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Thu, Mar 30, 2017 at 01:27:19PM +0300, Andrey Ryabinin wrote:
> vfree() can be used in any atomic context and there is no
> vfree_atomic() callers left, so let's remove it.
We might still get warnings though.
> @@ -1588,9 +1556,11 @@ void vfree(const void *addr)
>
> if (!addr)
> return;
> - if (unlikely(in_interrupt()))
> - __vfree_deferred(addr);
> - else
> + if (unlikely(in_interrupt())) {
> + struct vfree_deferred *p = this_cpu_ptr(&vfree_deferred);
> + if (llist_add((struct llist_node *)addr, &p->list))
> + schedule_work(&p->wq);
> + } else
> __vunmap(addr, 1);
> }
> EXPORT_SYMBOL(vfree);
If I disable preemption, then call vfree(), in_interrupt() will not be
true (I've only incremented preempt_count()), then __vunmap() calls
remove_vm_area() which calls might_sleep(), which will warn.
So I think this check needs to change from in_interrupt() to in_atomic().
Back to linux.kernel | Previous | Next | Find similar | Unroll thread
Re: [PATCH 4/4] mm/vmalloc: remove vfree_atomic() Matthew Wilcox <willy@infradead.org> - 2017-03-30 19:20 +0200
csiph-web