Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1613300
| From | Linus Torvalds <torvalds@linux-foundation.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: RFC: reject unknown open flags |
| Date | 2017-03-30 19:10 +0200 |
| Message-ID | <tqLK9-16I-3@gated-at.bofh.it> (permalink) |
| References | <tqLh7-GX-9@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Thu, Mar 30, 2017 at 9:33 AM, Christoph Hellwig <hch@lst.de> wrote:
This really harms
> when adding new flags, because applications can't just probe for the
> flag to actually work.
Side note: this whole argument is also incredibly idiotic from the
very beginning, regardless of the backwards compatibility issue.
But probing for flags is why we *could* add things like O_NOATIME etc
- exactly because it "just worked" with old kernels, and people could
just use the new flags knowing that it was a no-op on old kernels.
The whole concept of "probing for supported features" is very suspect.
It's a bad bad idea. Don't do it.
What kind of new flag did you even have in mind that would have such
broken semantics that it would completely change the other flags?
Becuase now I'm starting to think that the whole series has an even
deeper bug: stupid new features that were badly thought out and not
even described.
Linus
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
RFC: reject unknown open flags Christoph Hellwig <hch@lst.de> - 2017-03-30 18:40 +0200
[PATCH 1/2] fs: add a VALID_OPEN_FLAGS Christoph Hellwig <hch@lst.de> - 2017-03-30 18:40 +0200
[PATCH 2/2] fs: reject unknown open flags Christoph Hellwig <hch@lst.de> - 2017-03-30 18:40 +0200
Re: [PATCH 2/2] fs: reject unknown open flags Linus Torvalds <torvalds@linux-foundation.org> - 2017-03-30 19:10 +0200
Re: RFC: reject unknown open flags Linus Torvalds <torvalds@linux-foundation.org> - 2017-03-30 19:10 +0200
Re: RFC: reject unknown open flags Christoph Hellwig <hch@lst.de> - 2017-03-30 19:30 +0200
Re: RFC: reject unknown open flags Linus Torvalds <torvalds@linux-foundation.org> - 2017-03-30 20:30 +0200
Re: RFC: reject unknown open flags Christoph Hellwig <hch@lst.de> - 2017-03-30 20:30 +0200
Re: RFC: reject unknown open flags Linus Torvalds <torvalds@linux-foundation.org> - 2017-03-30 20:50 +0200
Re: RFC: reject unknown open flags Boaz Harrosh <boaz@plexistor.com> - 2017-03-30 22:10 +0200
Re: RFC: reject unknown open flags Paul Eggert <eggert@cs.ucla.edu> - 2017-03-30 21:10 +0200
Re: RFC: reject unknown open flags Linus Torvalds <torvalds@linux-foundation.org> - 2017-03-30 21:20 +0200
Re: RFC: reject unknown open flags Florian Weimer <fw@deneb.enyo.de> - 2017-03-30 21:40 +0200
csiph-web