Re: [PATCH V6 5/5] PCI/ASPM: move link_state cleanup to bridge remove

From	Sinan Kaya <okaya@codeaurora.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH V6 5/5] PCI/ASPM: move link_state cleanup to bridge remove
Date	2017-03-30 15:30 +0200
Message-ID	<tqIjf-6VF-11@gated-at.bofh.it> (permalink)
References	<tquSZ-5z9-5@gated-at.bofh.it> <tquT0-5z9-23@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 3/29/2017 7:04 PM, Sinan Kaya wrote:
>  	if (!parent || !parent->link_state)
>  		return;
>  
> +	if (pdev->has_secondary_link) {
> +		link = pdev->link_state;

I think I accidentally moved the parent check above this code
and broke the case where you can actually remove the root port.

I'll post v7 with reverting this change.

-- 
Sinan Kaya
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH V6 5/5] PCI/ASPM: move link_state cleanup to bridge remove Sinan Kaya <okaya@codeaurora.org> - 2017-03-30 01:10 +0200
  Re: [PATCH V6 5/5] PCI/ASPM: move link_state cleanup to bridge remove Sinan Kaya <okaya@codeaurora.org> - 2017-03-30 15:30 +0200

csiph-web