Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1613107

Re: [PATCH net-next 4/9] net: dsa: mv88e6xxx: allocate the number of ports

Show all headers | View raw

Hi Andrew,

Andrew Lunn <andrew@lunn.ch> writes:

> On Wed, Mar 29, 2017 at 04:30:15PM -0400, Vivien Didelot wrote:
>> The current code allocates DSA_MAX_PORTS ports for a Marvell dsa_switch
>> structure. Provide the exact number of ports so the corresponding
>> ds->num_ports is accurate.
>
> Is net/dsa/dsa.c: dsa_switch_setup() still used?  If it is, won't that
> invalidate your assumption about ds->num_ports.

I think dsa_switch_setup is part of the legacy code and is likely to be
removed soon.

But this is not an issue per-se. What happens if the switch is allocated
with DSA_MAX_PORTS ports instead of the correct number, is that the PVT
will be programmed to allow the non-existent port IDs to egress frames
on the CPU port and DSA links only.

Thanks,

        Vivien

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH net-next 4/9] net: dsa: mv88e6xxx: allocate the number of ports Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-03-29 22:40 +0200
  Re: [PATCH net-next 4/9] net: dsa: mv88e6xxx: allocate the number of  ports Andrew Lunn <andrew@lunn.ch> - 2017-03-30 16:00 +0200
    Re: [PATCH net-next 4/9] net: dsa: mv88e6xxx: allocate the number of ports Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-03-30 16:10 +0200

csiph-web