Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1612822

Re: [PATCH V1 1/1] mtd: mtk-nor: set controller to 4B mode with large capacity flash

Show all headers | View raw

On 03/30/2017 10:23 AM, Guochun Mao wrote:
> when nor's size larger than 16MByte, nor and controller should
> enter 4Byte mode simultaneously.
> 
> Signed-off-by: Guochun Mao <guochun.mao@mediatek.com>
> ---
>  drivers/mtd/spi-nor/mtk-quadspi.c |    7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/mtd/spi-nor/mtk-quadspi.c b/drivers/mtd/spi-nor/mtk-quadspi.c
> index e661877..05cd8a8 100644
> --- a/drivers/mtd/spi-nor/mtk-quadspi.c
> +++ b/drivers/mtd/spi-nor/mtk-quadspi.c
> @@ -369,6 +369,13 @@ static int mt8173_nor_write_reg(struct spi_nor *nor, u8 opcode, u8 *buf,
>  		/* We only handle 1 byte */
>  		ret = mt8173_nor_wr_sr(mt8173_nor, *buf);
>  		break;
> +	case SPINOR_OP_EN4B:
> +		/* Set nor controller to 4-byte address mode,
> +		 * and simultaneously set nor flash.
> +		 * This case should cooperate with default operation.
> +		 */
> +		writeb(readb(mt8173_nor->base + MTK_NOR_DUAL_REG) | 0x10,
> +				mt8173_nor->base + MTK_NOR_DUAL_REG);

And what happens on READ then ? Who clears that bit when protocol
changes ? You probably want something like cqspi_set_protocol()
instead, which is invoked from {read,write}{,_reg}() and erase().

>  	default:
>  		ret = mt8173_nor_do_tx_rx(mt8173_nor, opcode, buf, len, NULL, 0);
>  		if (ret)
> 


-- 
Best regards,
Marek Vasut

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH V1] mtd: mtk-nor: set controller to 4B mode with large capacity flash Guochun Mao <guochun.mao@mediatek.com> - 2017-03-30 10:30 +0200
  [PATCH V1 1/1] mtd: mtk-nor: set controller to 4B mode with large capacity flash Guochun Mao <guochun.mao@mediatek.com> - 2017-03-30 10:30 +0200
    Re: [PATCH V1 1/1] mtd: mtk-nor: set controller to 4B mode with large  capacity flash Marek Vasut <marek.vasut@gmail.com> - 2017-03-30 12:10 +0200
    Re: [PATCH V1 1/1] mtd: mtk-nor: set controller to 4B mode with large  capacity flash Cyrille Pitchen <cyrille.pitchen@wedev4u.fr> - 2017-03-30 21:00 +0200
      Re: [PATCH V1 1/1] mtd: mtk-nor: set controller to 4B mode with  large capacity flash Guochun Mao <guochun.mao@mediatek.com> - 2017-03-31 04:30 +0200
        Re: [PATCH V1 1/1] mtd: mtk-nor: set controller to 4B mode with large  capacity flash Cyrille Pitchen <cyrille.pitchen@wedev4u.fr> - 2017-03-31 11:00 +0200
          Re: [PATCH V1 1/1] mtd: mtk-nor: set controller to 4B mode with  large capacity flash Guochun Mao <guochun.mao@mediatek.com> - 2017-04-05 05:40 +0200

csiph-web