Re: [PATCH] selftests/vm: Set mmap()'s fd as -1 for MAP_ANONYMOUS flag

From	Andrew Morton <akpm@linux-foundation.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] selftests/vm: Set mmap()'s fd as -1 for MAP_ANONYMOUS flag
Date	2017-03-29 01:50 +0200
Message-ID	<tq92a-6KA-23@gated-at.bofh.it> (permalink)
References	<tlhjH-8i6-1@gated-at.bofh.it> <tnZzX-3c4-3@gated-at.bofh.it> <toAzx-4jh-25@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, 24 Mar 2017 10:47:55 -0600 Shuah Khan <shuah@kernel.org> wrote:

> > On Wed, Mar 15, 2017 at 10:19 PM, SeongJae Park <sj38.park@gmail.com> wrote:
> >> Man page of mmap() says that portable applications should ensure fd
> >> argument to be -1 if MAP_ANONYMOUS flag is set as below:
> >> ```
> >> The  mapping is not backed by any file; its contents are initialized to
> >> zero.  The fd and offset arguments are ignored; however, some
> >> implementations require  fd  to be  -1  if  MAP_ANONYMOUS  (or
> >> MAP_ANON)  is specified, and portable applications
> >> should ensure this.
> >> ```
> >>
> >> However, few mmap() calls under selftests/vm/ uses 0 as fd though they
> >> use MAP_ANONYMOUS flag.  This commit changes the argument to be -1 as
> >> recommended.
> 
> Hi Andrew,
> 
> Do you have comments on this patch? Please Ack it if you would
> like me to take it thorugh ksefltest tree.

Acked-by: Andrew Morton <akpm@linux-foundation.org>

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] selftests/vm: Set mmap()'s fd as -1 for MAP_ANONYMOUS  flag Andrew Morton <akpm@linux-foundation.org> - 2017-03-29 01:50 +0200

csiph-web