Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1611435

Re: [PATCH v2] fault-inject: support systematic fault injection

Show all headers | View raw

2017-03-28 22:01 GMT+09:00 Dmitry Vyukov <dvyukov@google.com>:
> Add /proc/self/task/<current-tid>/fail-nth file that allows failing
> 0-th, 1-st, 2-nd and so on calls systematically.
> Excerpt from the added documentation:
>
> ===
> Write to this file of integer N makes N-th call in the current task fail
> (N is 0-based). Read from this file returns a single char 'Y' or 'N'
> that says if the fault setup with a previous write to this file was
> injected or not, and disables the fault if it wasn't yet injected.
> Note that this file enables all types of faults (slab, futex, etc).
> This setting takes precedence over all other generic settings like
> probability, interval, times, etc. But per-capability settings
> (e.g. fail_futex/ignore-private) take precedence over it.
> This feature is intended for systematic testing of faults in a single
> system call. See an example below.
> ===

This asymmetric read/write interface looks a bit odd. (write a string
representation of integer, but read Y or N).

How about just return the string representation of task->fail_nth for
read and let the user space tools check if it is zero or not?

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2] fault-inject: support systematic fault injection Dmitry Vyukov <dvyukov@google.com> - 2017-03-28 15:10 +0200
  Re: [PATCH v2] fault-inject: support systematic fault injection Andrew Morton <akpm@linux-foundation.org> - 2017-03-28 23:50 +0200
  Re: [PATCH v2] fault-inject: support systematic fault injection Akinobu Mita <akinobu.mita@gmail.com> - 2017-03-29 01:50 +0200
  Re: [PATCH v2] fault-inject: support systematic fault injection Andrew Morton <akpm@linux-foundation.org> - 2017-03-31 01:10 +0200
  Re: [PATCH v2] fault-inject: support systematic fault injection Akinobu Mita <akinobu.mita@gmail.com> - 2017-04-04 17:00 +0200
  Re: [PATCH v2] fault-inject: support systematic fault injection Michal Hocko <mhocko@kernel.org> - 2017-04-06 20:40 +0200
    Re: [PATCH v2] fault-inject: support systematic fault injection Akinobu Mita <akinobu.mita@gmail.com> - 2017-04-07 18:50 +0200
      Re: [PATCH v2] fault-inject: support systematic fault injection Dmitry Vyukov <dvyukov@google.com> - 2017-04-08 19:50 +0200
        Re: [PATCH v2] fault-inject: support systematic fault injection Akinobu Mita <akinobu.mita@gmail.com> - 2017-04-09 12:50 +0200

csiph-web