Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1611295
| From | Jerome Brunet <jbrunet@baylibre.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2, 3/3] tty/serial: meson_uart: add the core clock handling to the driver |
| Date | 2017-03-28 21:20 +0200 |
| Message-ID | <tq4OS-3L1-25@gated-at.bofh.it> (permalink) |
| References | <tpVBT-5sY-3@gated-at.bofh.it> <tpVBU-5sY-39@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Tue, 2017-03-28 at 11:25 +0200, Helmut Klein wrote:
> This patch gets the core clock as provided by the DT and enables it.
> The code was taken from Amlogic's serial driver, and was tested on my
> board.
>
> Signed-off-by: Helmut Klein <hgkr.klein@gmail.com>
> ---
> drivers/tty/serial/meson_uart.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/drivers/tty/serial/meson_uart.c b/drivers/tty/serial/meson_uart.c
> index 60f16795d16b..cb99112288eb 100644
> --- a/drivers/tty/serial/meson_uart.c
> +++ b/drivers/tty/serial/meson_uart.c
> @@ -600,6 +600,7 @@ static int meson_uart_probe(struct platform_device *pdev)
> struct resource *res_mem, *res_irq;
> struct uart_port *port;
> struct clk *clk;
> + struct clk *core_clk;
> int ret = 0;
>
> if (pdev->dev.of_node)
> @@ -625,6 +626,15 @@ static int meson_uart_probe(struct platform_device *pdev)
> if (!port)
> return -ENOMEM;
>
> + core_clk = devm_clk_get(&pdev->dev, "core");
> + if (!IS_ERR(core_clk)) {
> + ret = clk_prepare_enable(core_clk);
> + if (ret) {
> + dev_err(&pdev->dev, "couldn't enable clkc\n");
> + return ret;
> + }
> + }
> +
> clk = clk_get(&pdev->dev, NULL);
Now that you have 2 clocks, shouldn't this be named as well ?
> if (IS_ERR(clk))
> return PTR_ERR(clk);
> --
> 2.11.0
>
>
> _______________________________________________
> linux-amlogic mailing list
> linux-amlogic@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-amlogic
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v2,3/3] tty/serial: meson_uart: add the core clock handling to the driver Helmut Klein <hgkr.klein@gmail.com> - 2017-03-28 11:30 +0200
Re: [PATCH v2, 3/3] tty/serial: meson_uart: add the core clock handling to the driver Jerome Brunet <jbrunet@baylibre.com> - 2017-03-28 21:20 +0200
Re: [PATCH v2, 3/3] tty/serial: meson_uart: add the core clock handling to the driver Helmut Klein <hgkr.klein@gmail.com> - 2017-03-29 11:50 +0200
csiph-web