Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1611267

Re: [PATCH 1/3] mailbox: always wait in mbox_send_message for blocking Tx mode

Show all headers | View raw

Hi Sudeep,

On Tue, Mar 21, 2017 at 5:00 PM, Sudeep Holla <sudeep.holla@arm.com> wrote:
> There exists a race when msg_submit return immediately as there was an
> active request being processed which may have completed just before it's
> checked again in mbox_send_message. This will result in return to the
> caller without waiting in mbox_send_message even when it's blocking Tx.
>
> This patch fixes the issue by waiting for the completion always if Tx
> is in blocking mode.
>
> Fixes: 2b6d83e2b8b7 ("mailbox: Introduce framework for mailbox")
> Cc: Jassi Brar <jassisinghbrar@gmail.com>
> Reported-by: Alexey Klimov <alexey.klimov@arm.com>
> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
> ---
>  drivers/mailbox/mailbox.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> Hi Jassi,
>
> Here are fixes for few issues we encountered when dealing with multiple
> requests on multiple channels simultaneously.
>
Thanks for finding the bug.

I see patch-1 tries to fix the bug.  Patch-2,3 try to fix the
ramifications of the bug
but they may change behaviour for some users. Do you face any issue even after
applying patch-1 ?

Thanks

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH 1/3] mailbox: always wait in mbox_send_message for  blocking Tx mode Jassi Brar <jassisinghbrar@gmail.com> - 2017-03-28 20:30 +0200
  Re: [PATCH 1/3] mailbox: always wait in mbox_send_message for  blocking Tx mode Sudeep Holla <sudeep.holla@arm.com> - 2017-03-29 13:40 +0200
    Re: [PATCH 1/3] mailbox: always wait in mbox_send_message for  blocking Tx mode Jassi Brar <jassisinghbrar@gmail.com> - 2017-03-29 19:50 +0200

csiph-web