Re: [PATCH v2 08/22] lib: implement Devres ioremap_nopost() interface

From	Tejun Heo <tj@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 08/22] lib: implement Devres ioremap_nopost() interface
Date	2017-03-28 18:00 +0200
Message-ID	<tq1Hj-1nl-7@gated-at.bofh.it> (permalink)
References	<tpzBo-66r-9@gated-at.bofh.it> <tpzBp-66r-45@gated-at.bofh.it> <tpOqL-f2-39@gated-at.bofh.it> <tq0Lg-Gt-23@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hello,

On Tue, Mar 28, 2017 at 03:50:03PM +0100, Lorenzo Pieralisi wrote:
> > I know this comment was just copied from other devm_ioremap*()
> > interfaces, but I think it's slightly misleading to call this the "BUS
> > offset".  That suggests this is a bus address, but it is not.  Maybe
> > it should be "resource address" or similar?
> > 
> > I propose a separate patch to update the existing comments, followed
> > by this patch to add this new one.
> 
> I agree with you, maybe Tejun has more context on why that parameter
> is called BUS offset ? Anyway, I can easily do what you suggest above,
> just asking Tejun if there is something I am missing.

I'm pretty sure I copied it from somewhere without thinking much about
it.  Please feel free to change.

Thanks.

-- 
tejun

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2 08/22] lib: implement Devres ioremap_nopost() interface Bjorn Helgaas <helgaas@kernel.org> - 2017-03-28 03:50 +0200
  Re: [PATCH v2 08/22] lib: implement Devres ioremap_nopost() interface Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> - 2017-03-28 17:00 +0200
    Re: [PATCH v2 08/22] lib: implement Devres ioremap_nopost() interface Tejun Heo <tj@kernel.org> - 2017-03-28 18:00 +0200

csiph-web