Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1609607

Re: [alsa-devel] [PATCH] ASoC: intel: remove unused variable data and associated code

Show all headers | View raw

On 2017年03月22日 22:36, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The variable 'data' is assigned null and never re-assigned. There
> is also a redundant check for data being non-null which is always
> false, so remove this and the variable data and dma_addr as they
> are not used once the dead code has been removed.
>
> Detected with CoverityScan, CID#1324015 ("'Constant' variable gaurds
> dead code")
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Thank you for fixing it.

Acked-by: Jie Yang <yang.jie@intel.com>

thanks,
~Keyon

> ---
>   sound/soc/intel/haswell/sst-haswell-ipc.c | 6 ------
>   1 file changed, 6 deletions(-)
>
> diff --git a/sound/soc/intel/haswell/sst-haswell-ipc.c b/sound/soc/intel/haswell/sst-haswell-ipc.c
> index a3459d1682a6..d33bdaf92c57 100644
> --- a/sound/soc/intel/haswell/sst-haswell-ipc.c
> +++ b/sound/soc/intel/haswell/sst-haswell-ipc.c
> @@ -2000,10 +2000,8 @@ int sst_hsw_module_set_param(struct sst_hsw *hsw,
>   	u32 param_size, char *param)
>   {
>   	int ret;
> -	unsigned char *data = NULL;
>   	u32 header = 0;
>   	u32 payload_size = 0, transfer_parameter_size = 0;
> -	dma_addr_t dma_addr = 0;
>   	struct sst_hsw_transfer_parameter *parameter;
>   	struct device *dev = hsw->dev;
>
> @@ -2047,10 +2045,6 @@ int sst_hsw_module_set_param(struct sst_hsw *hsw,
>
>   	kfree(parameter);
>
> -	if (data)
> -		dma_free_coherent(hsw->dsp->dma_dev,
> -			param_size, (void *)data, dma_addr);
> -
>   	return ret;
>   }
>
>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] ASoC: intel: remove unused variable data and associated code Colin King <colin.king@canonical.com> - 2017-03-22 15:40 +0100
  Re: [alsa-devel] [PATCH] ASoC: intel: remove unused variable data and  associated code Keyon Jie <yang.jie@linux.intel.com> - 2017-03-27 11:40 +0200
  Applied "ASoC: intel: remove unused variable data and associated code" to the asoc tree Mark Brown <broonie@kernel.org> - 2017-03-27 13:40 +0200

csiph-web