Re: [PATCH] trace: Make trace_hwlat timestamp y2038 safe

From	kbuild test robot <lkp@intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] trace: Make trace_hwlat timestamp y2038 safe
Date	2017-03-27 12:10 +0200
Message-ID	<tpzL5-6pP-55@gated-at.bofh.it> (permalink)
References	<tpnqx-5w1-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi Deepa,

[auto build test WARNING on tip/perf/core]
[also build test WARNING on v4.11-rc4 next-20170327]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Deepa-Dinamani/trace-Make-trace_hwlat-timestamp-y2038-safe/20170327-150010
config: x86_64-randconfig-s2-03271627 (attached as .config)
compiler: gcc-4.4 (Debian 4.4.7-8) 4.4.7
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All warnings (new ones prefixed by >>):

   kernel/trace/trace_output.c: In function 'trace_hwlat_print':
>> kernel/trace/trace_output.c:1168: warning: format '%lld' expects type 'long long int', but argument 6 has type '__kernel_time_t'
   kernel/trace/trace_output.c: In function 'trace_hwlat_raw':
   kernel/trace/trace_output.c:1202: warning: format '%lld' expects type 'long long int', but argument 5 has type '__kernel_time_t'

vim +1168 kernel/trace/trace_output.c

e7c15cd8 Steven Rostedt (Red Hat  2016-06-23  1152) /* TRACE_HWLAT */
e7c15cd8 Steven Rostedt (Red Hat  2016-06-23  1153) static enum print_line_t
e7c15cd8 Steven Rostedt (Red Hat  2016-06-23  1154) trace_hwlat_print(struct trace_iterator *iter, int flags,
e7c15cd8 Steven Rostedt (Red Hat  2016-06-23  1155) 		  struct trace_event *event)
e7c15cd8 Steven Rostedt (Red Hat  2016-06-23  1156) {
e7c15cd8 Steven Rostedt (Red Hat  2016-06-23  1157) 	struct trace_entry *entry = iter->ent;
e7c15cd8 Steven Rostedt (Red Hat  2016-06-23  1158) 	struct trace_seq *s = &iter->seq;
e7c15cd8 Steven Rostedt (Red Hat  2016-06-23  1159) 	struct hwlat_entry *field;
e7c15cd8 Steven Rostedt (Red Hat  2016-06-23  1160) 
e7c15cd8 Steven Rostedt (Red Hat  2016-06-23  1161) 	trace_assign_type(field, entry);
e7c15cd8 Steven Rostedt (Red Hat  2016-06-23  1162) 
df001907 Deepa Dinamani           2017-03-26  1163  	trace_seq_printf(s, "#%-5u inner/outer(us): %4llu/%-5llu ts:%lld.%09ld",
e7c15cd8 Steven Rostedt (Red Hat  2016-06-23  1164) 			 field->seqnum,
e7c15cd8 Steven Rostedt (Red Hat  2016-06-23  1165) 			 field->duration,
e7c15cd8 Steven Rostedt (Red Hat  2016-06-23  1166) 			 field->outer_duration,
e7c15cd8 Steven Rostedt (Red Hat  2016-06-23  1167) 			 field->timestamp.tv_sec,
e7c15cd8 Steven Rostedt (Red Hat  2016-06-23 @1168) 			 field->timestamp.tv_nsec);
e7c15cd8 Steven Rostedt (Red Hat  2016-06-23  1169) 
7b2c8625 Steven Rostedt (Red Hat  2016-08-04  1170) 	if (field->nmi_count) {
7b2c8625 Steven Rostedt (Red Hat  2016-08-04  1171) 		/*
7b2c8625 Steven Rostedt (Red Hat  2016-08-04  1172) 		 * The generic sched_clock() is not NMI safe, thus
7b2c8625 Steven Rostedt (Red Hat  2016-08-04  1173) 		 * we only record the count and not the time.
7b2c8625 Steven Rostedt (Red Hat  2016-08-04  1174) 		 */
7b2c8625 Steven Rostedt (Red Hat  2016-08-04  1175) 		if (!IS_ENABLED(CONFIG_GENERIC_SCHED_CLOCK))
7b2c8625 Steven Rostedt (Red Hat  2016-08-04  1176) 			trace_seq_printf(s, " nmi-total:%llu",

:::::: The code at line 1168 was first introduced by commit
:::::: e7c15cd8a113335cf7154f027c9c8da1a92238ee tracing: Added hardware latency tracer

:::::: TO: Steven Rostedt (Red Hat) <rostedt@goodmis.org>
:::::: CC: Steven Rostedt <rostedt@goodmis.org>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] trace: Make trace_hwlat timestamp y2038 safe Deepa Dinamani <deepa.kernel@gmail.com> - 2017-03-26 23:00 +0200
  Re: [PATCH] trace: Make trace_hwlat timestamp y2038 safe kbuild test robot <lkp@intel.com> - 2017-03-27 11:30 +0200
    Re: [PATCH] trace: Make trace_hwlat timestamp y2038 safe Arnd Bergmann <arnd@arndb.de> - 2017-03-27 12:00 +0200
      Re: [PATCH] trace: Make trace_hwlat timestamp y2038 safe Steven Rostedt <rostedt@goodmis.org> - 2017-03-27 16:40 +0200
        Re: [PATCH] trace: Make trace_hwlat timestamp y2038 safe Arnd Bergmann <arnd@arndb.de> - 2017-03-27 17:00 +0200
          Re: [PATCH] trace: Make trace_hwlat timestamp y2038 safe Arnd Bergmann <arnd@arndb.de> - 2017-03-27 17:40 +0200
            Re: [PATCH] trace: Make trace_hwlat timestamp y2038 safe Steven Rostedt <rostedt@goodmis.org> - 2017-03-27 18:20 +0200
          Re: [PATCH] trace: Make trace_hwlat timestamp y2038 safe Steven Rostedt <rostedt@goodmis.org> - 2017-03-27 17:40 +0200
          Re: [PATCH] trace: Make trace_hwlat timestamp y2038 safe Deepa Dinamani <deepa.kernel@gmail.com> - 2017-03-27 23:10 +0200
            Re: [PATCH] trace: Make trace_hwlat timestamp y2038 safe Arnd Bergmann <arnd@arndb.de> - 2017-03-28 09:30 +0200
  Re: [PATCH] trace: Make trace_hwlat timestamp y2038 safe kbuild test robot <lkp@intel.com> - 2017-03-27 12:10 +0200

csiph-web