Re: [PATCH V8 1/3] irq: Add flags to request_percpu_irq function

From	Andrew Jones <drjones@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH V8 1/3] irq: Add flags to request_percpu_irq function
Date	2017-03-27 10:50 +0200
Message-ID	<tpyvE-5he-17@gated-at.bofh.it> (permalink)
References	<tof22-5ye-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Mar 23, 2017 at 06:42:01PM +0100, Daniel Lezcano wrote:
> diff --git a/drivers/clocksource/timer-nps.c b/drivers/clocksource/timer-nps.c
> index da1f798..dbdb622 100644
> --- a/drivers/clocksource/timer-nps.c
> +++ b/drivers/clocksource/timer-nps.c
> @@ -256,7 +256,7 @@ static int __init nps_setup_clockevent(struct device_node *node)
>  		return ret;
>  
>  	/* Needs apriori irq_set_percpu_devid() done in intc map function */
> -	ret = request_percpu_irq(nps_timer0_irq, timer_irq_handler,
> +	ret = request_percpu_irq(nps_timer0_irq, timer_irq_handler, IRQF_TIMER,
>  				 "Timer0 (per-cpu-tick)",
>  				 &nps_clockevent_device);

Wrong parameter order here.

drew

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH V8 1/3] irq: Add flags to request_percpu_irq function Daniel Lezcano <daniel.lezcano@linaro.org> - 2017-03-23 18:50 +0100
  [PATCH V8 3/3] irq: Compute the periodic interval for interrupts Daniel Lezcano <daniel.lezcano@linaro.org> - 2017-03-23 18:50 +0100
    Re: [PATCH V8 3/3] irq: Compute the periodic interval for  interrupts Nicolas Pitre <nicolas.pitre@linaro.org> - 2017-03-23 20:50 +0100
      Re: [PATCH V8 3/3] irq: Compute the periodic interval for interrupts Daniel Lezcano <daniel.lezcano@linaro.org> - 2017-03-24 15:20 +0100
  Re: [PATCH V8 1/3] irq: Add flags to request_percpu_irq function Vineet Gupta <Vineet.Gupta1@synopsys.com> - 2017-03-23 19:40 +0100
  Re: [PATCH V8 1/3] irq: Add flags to request_percpu_irq function Mark Rutland <mark.rutland@arm.com> - 2017-03-23 20:00 +0100
    Re: [PATCH V8 1/3] irq: Add flags to request_percpu_irq function Daniel Lezcano <daniel.lezcano@linaro.org> - 2017-03-23 20:30 +0100
  Re: [PATCH V8 1/3] irq: Add flags to request_percpu_irq function Andrew Jones <drjones@redhat.com> - 2017-03-27 10:50 +0200

csiph-web