Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1609568

Re: [PATCH v1 1/2] auxdisplay: Move panel.c to drivers/auxdisplay folder

Show all headers | View raw

On Mon, Mar 27, 2017 at 10:11 AM, Willy TARREAU <wtarreau@haproxy.com> wrote:
> On Fri, Mar 24, 2017 at 04:19:43PM +0100, Geert Uytterhoeven wrote:
>> On Fri, Mar 24, 2017 at 3:29 PM, Andy Shevchenko
>> <andriy.shevchenko@linux.intel.com> wrote:
>> > On Fri, 2017-03-24 at 15:19 +0100, Geert Uytterhoeven wrote:
>> >> On Fri, Mar 24, 2017 at 3:06 PM, Andy Shevchenko
>> >> <andriy.shevchenko@linux.intel.com> wrote:
>> >> > It looks like panel.c belongs to auxdisplay subsystem.
>> >> >
>> >> > Move it to drivers/auxdisplay folder.
>> >> > No functional changes intended.
>> >>
>> >> I didn't move it to drivers/auxdisplay/ because it not only provides
>> >> auxdisplay functionality, but also keypad functionality.
>> >
>> > Yes, I have noticed this. But keypad functionality is optional while
>> > panel is main one. I think you would agree on this.
>>
>> I don't care that much, though. Willy?
>
> Well, as long as it continues to work, I don't really care either. The
> only thing to keep in mind is that it can be difficult to split the
> driver in two since in some cases it's possible to use the same lines
> for keypad and lcd.

Ideally, it should be replaced by a glue driver using charlcd, matrix-keypad,
and (still to be written?) gpio-parport ;-)

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v1 1/2] auxdisplay: Move panel.c to drivers/auxdisplay folder Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-03-24 15:10 +0100
  [PATCH v1 2/2] auxdisplay: Move arm-charlcd.c to drivers/auxdisplay folder Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-03-24 15:10 +0100
    Re: [PATCH v1 2/2] auxdisplay: Move arm-charlcd.c to  drivers/auxdisplay folder Linus Walleij <linus.walleij@linaro.org> - 2017-03-24 16:20 +0100
  Re: [PATCH v1 1/2] auxdisplay: Move panel.c to drivers/auxdisplay folder Geert Uytterhoeven <geert@linux-m68k.org> - 2017-03-24 15:30 +0100
    Re: [PATCH v1 1/2] auxdisplay: Move panel.c to drivers/auxdisplay  folder Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-03-24 15:40 +0100
      Re: [PATCH v1 1/2] auxdisplay: Move panel.c to drivers/auxdisplay folder Geert Uytterhoeven <geert@linux-m68k.org> - 2017-03-24 16:30 +0100
        Re: [PATCH v1 1/2] auxdisplay: Move panel.c to drivers/auxdisplay folder Willy TARREAU <wtarreau@haproxy.com> - 2017-03-27 10:20 +0200
          Re: [PATCH v1 1/2] auxdisplay: Move panel.c to drivers/auxdisplay folder Geert Uytterhoeven <geert@linux-m68k.org> - 2017-03-27 10:30 +0200
            Re: [PATCH v1 1/2] auxdisplay: Move panel.c to drivers/auxdisplay folder Willy TARREAU <wtarreau@haproxy.com> - 2017-03-27 11:30 +0200
              Re: [PATCH v1 1/2] auxdisplay: Move panel.c to drivers/auxdisplay  folder Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-03-30 13:30 +0200
                Re: [PATCH v1 1/2] auxdisplay: Move panel.c to drivers/auxdisplay folder Willy TARREAU <wtarreau@haproxy.com> - 2017-03-30 15:00 +0200
                Re: [PATCH v1 1/2] auxdisplay: Move panel.c to drivers/auxdisplay  folder Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-04-04 18:30 +0200
        Re: [PATCH v1 1/2] auxdisplay: Move panel.c to drivers/auxdisplay folder Geert Uytterhoeven <geert@linux-m68k.org> - 2017-03-27 16:20 +0200
        Re: [PATCH v1 1/2] auxdisplay: Move panel.c to drivers/auxdisplay folder Arnd Bergmann <arnd@arndb.de> - 2017-03-27 16:30 +0200
  Re: [PATCH v1 1/2] auxdisplay: Move panel.c to drivers/auxdisplay folder Geert Uytterhoeven <geert@linux-m68k.org> - 2017-03-30 13:50 +0200

csiph-web