Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1609592

Re: [PATCH 2/6] hpet: remove unused writeq/readq function definitions

From Corentin Labbe <clabbe.montjoie@gmail.com>
Newsgroups linux.kernel
Subject Re: [PATCH 2/6] hpet: remove unused writeq/readq function definitions
Date 2017-03-27 11:00 +0200
Message-ID <tpyFk-5la-33@gated-at.bofh.it> (permalink)
References <toVaW-2cv-15@gated-at.bofh.it> <tpqeJ-7qW-7@gated-at.bofh.it> <tpxJg-4EH-25@gated-at.bofh.it> <tpxSW-4Xx-23@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Mon, Mar 27, 2017 at 09:51:23AM +0200, Clemens Ladisch wrote:
> Corentin Labbe wrote:
> > On Mon, Mar 27, 2017 at 07:49:34AM +0800, kbuild test robot wrote:
> >>    drivers//char/hpet.c: In function 'hpet_timer_set_irq':
> >>>> drivers//char/hpet.c:207:7: error: implicit declaration of function 'readq' [-Werror=implicit-function-declaration]
> >
> > Wrongly believed that x86 and x86_64 shared writeq/readq.
> > Sorry, I will drop this patch
> >
> > Since the writeq/readq redefined is present in lots of other file, perhaps adding it to i386 could be done.
> 
> Just use <linux/io-64-nonatomic-lo-hi.h> instead.
> 

Thanks, much easier than add writeq/readq to whole x86

Regards

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/6] hpet: misc fix Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-03-25 15:50 +0100
  [PATCH 2/6] hpet: remove unused writeq/readq function definitions Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-03-25 15:50 +0100
    Re: [PATCH 2/6] hpet: remove unused writeq/readq function definitions kbuild test robot <lkp@intel.com> - 2017-03-27 02:00 +0200
      Re: [PATCH 2/6] hpet: remove unused writeq/readq function definitions Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-03-27 10:00 +0200
        Re: [PATCH 2/6] hpet: remove unused writeq/readq function definitions Clemens Ladisch <clemens@ladisch.de> - 2017-03-27 10:10 +0200
          Re: [PATCH 2/6] hpet: remove unused writeq/readq function definitions Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-03-27 11:00 +0200
  [PATCH 1/6] hpet: remove unused variable hpet in hpet_ioctl_common Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-03-25 15:50 +0100

csiph-web