Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1609550
| From | Samuel Thibault <samuel.thibault@ens-lyon.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] staging: speakup: fix warning for static declaration |
| Date | 2017-03-27 10:10 +0200 |
| Message-ID | <tpxSV-4Xx-3@gated-at.bofh.it> (permalink) |
| References | <tpxpU-4s4-9@gated-at.bofh.it> <tpxJf-4EH-15@gated-at.bofh.it> |
| Organization | I am not organized |
Okash Khawaja, on lun. 27 mars 2017 08:51:02 +0100, wrote: > Thanks for this :) Could you also move the function higher in the same > file - above line 139 where all static functions are defined? I'd say no need for this. spk_serial_in is just above. Moving functions just for the sake of static vs non-static does not make the code more readable to my eyes :) (and it makes tracking changes harder in git annotate) Samuel
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] staging: speakup: fix warning for static declaration "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-03-27 09:40 +0200
Re: [PATCH] staging: speakup: fix warning for static declaration Okash Khawaja <okash.khawaja@gmail.com> - 2017-03-27 10:00 +0200
Re: [PATCH] staging: speakup: fix warning for static declaration Samuel Thibault <samuel.thibault@ens-lyon.org> - 2017-03-27 10:10 +0200
Re: [PATCH] staging: speakup: fix warning for static declaration Okash Khawaja <okash.khawaja@gmail.com> - 2017-03-27 10:50 +0200
Re: [PATCH] staging: speakup: fix warning for static declaration Samuel Thibault <samuel.thibault@ens-lyon.org> - 2017-03-27 10:00 +0200
csiph-web