Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1609469
| From | Masahiro Yamada <yamada.masahiro@socionext.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v10 07/11] btrfs_tree.h: fix include from userland |
| Date | 2017-03-27 08:00 +0200 |
| Message-ID | <tpvR8-3fY-13@gated-at.bofh.it> (permalink) |
| References | <tjI4F-6z3-5@gated-at.bofh.it> <tkUdr-cW-3@gated-at.bofh.it> <tkUds-cW-21@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Hi Nicolas, 2017-03-14 21:54 GMT+09:00 Nicolas Dichtel <nicolas.dichtel@6wind.com>: > This patch prepares the uapi export by fixing the following errors: > > .../linux/btrfs_tree.h:283:2: error: #error "UUID items require BTRFS_UUID_SIZE == 16!" > #error "UUID items require BTRFS_UUID_SIZE == 16!" > > .../linux/btrfs_tree.h:390:12: error: ‘BTRFS_UUID_SIZE’ undeclared here (not in a function) > __u8 uuid[BTRFS_UUID_SIZE]; > ^ > .../linux/btrfs_tree.h:796:16: error: ‘BTRFS_DEV_STAT_VALUES_MAX’ undeclared here (not in a function) > __le64 values[BTRFS_DEV_STAT_VALUES_MAX]; > > Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com> > --- > include/uapi/linux/btrfs_tree.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/uapi/linux/btrfs_tree.h b/include/uapi/linux/btrfs_tree.h > index 6a261cb52d95..6a754ada59af 100644 > --- a/include/uapi/linux/btrfs_tree.h > +++ b/include/uapi/linux/btrfs_tree.h > @@ -2,6 +2,7 @@ > #define _BTRFS_CTREE_H_ > > #include <linux/types.h> > +#include <linux/btrfs.h> > Can you move <linux/types.h> below <linux/btrfs.h> to sort the includes alphabetically? This also applies to: include/uapi/linux/qrtr.h in 06/11 include/uapi/linux/cryptouser.h in 08/11 -- Best Regards Masahiro Yamada
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v10 07/11] btrfs_tree.h: fix include from userland Nicolas Dichtel <nicolas.dichtel@6wind.com> - 2017-03-14 14:00 +0100
Re: [PATCH v10 07/11] btrfs_tree.h: fix include from userland Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-03-27 08:00 +0200
Re: [PATCH v10 07/11] btrfs_tree.h: fix include from userland Nicolas Dichtel <nicolas.dichtel@6wind.com> - 2017-03-27 11:50 +0200
csiph-web