Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1609394

Re: [RFC PATCH 1/1] tpm_tis: convert to using locality callbacks

From Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
Newsgroups linux.kernel
Subject Re: [RFC PATCH 1/1] tpm_tis: convert to using locality callbacks
Date 2017-03-26 22:40 +0200
Message-ID <tpn7c-5dN-3@gated-at.bofh.it> (permalink)
References <tp0aB-5Sl-3@gated-at.bofh.it> <tp0aC-5Sl-9@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Sat, Mar 25, 2017 at 01:05:21PM -0700, Jerry Snitselaar wrote:

> @@ -672,7 +658,7 @@ void tpm_tis_remove(struct tpm_chip *chip)
>  		interrupt = 0;
>  
>  	tpm_tis_write32(priv, reg, ~TPM_GLOBAL_INT_ENABLE & interrupt);
> -	release_locality(chip, priv->locality, 1);
> +	release_locality(chip, priv->locality);

Why is this done during remove? The tpm core should now keep things so
that there is not a requested locality except during command so execution
we should not get here with a requested locality..

Jason

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[RFC PATCH 0/1] tpm_tis: convert to use locality callbacks Jerry Snitselaar <jsnitsel@redhat.com> - 2017-03-25 21:10 +0100
  [RFC PATCH 1/1] tpm_tis: convert to using locality callbacks Jerry Snitselaar <jsnitsel@redhat.com> - 2017-03-25 21:10 +0100
    Re: [RFC PATCH 1/1] tpm_tis: convert to using locality callbacks Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2017-03-26 22:40 +0200
      Re: [RFC PATCH 1/1] tpm_tis: convert to using locality callbacks Jerry Snitselaar <jsnitsel@redhat.com> - 2017-03-27 00:50 +0200
    Re: [RFC PATCH 1/1] tpm_tis: convert to using locality callbacks Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2017-03-27 07:30 +0200

csiph-web