Re: [PATCH 0/5] Convert to use devm_*() for amba attached modules

From	Leo Yan <leo.yan@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 0/5] Convert to use devm_*() for amba attached modules
Date	2017-03-26 17:50 +0200
Message-ID	<tpiAx-1SU-1@gated-at.bofh.it> (permalink)
References	<tphEt-1ge-5@gated-at.bofh.it> <tpihc-1Mu-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sun, Mar 26, 2017 at 05:20:50PM +0200, Alexandre Belloni wrote:
> On 26/03/2017 at 22:41:49 +0800, Leo Yan wrote:
> > When review device driver modules which attach to amba bus, found
> > several modules are not using devm_*() apis to manage resource. As
> > result, some drivers have memory leakage or missing iomem unmapping
> > when rmmod module. And the code has many "goto" tags to handle
> > different failures.
> > 
> > So this patch series is to convert to use devm_*() for moudules which
> > are attached to amba bus to manage resource and get more robust and
> > neat code.
> > 
> > Patch 0003 "drivers/rtc/rtc-pl031.c: Convert to use devm_*()" has been
> > verified on 96boards Hikey. Other patches can pass building but have
> > not really tested on hardware.
> > 
> 
> If your plan is to actually remove usage of
> amba_request_regions() and amba_release_regions(), you should do so in
> its own patch sets instead of hiding that in a useless cleanup series.

Just curious, from Russell's replying for patch 0005, IIUC we cannot
totally remove usage of amba_request_regions() and
amba_release_regions(), there have some coner case should use
amba_request_regions() + ioremap().

Does it make sense to remove most usage of amba_request_regions() and
amba_release_regions() but we still keep these two functions in the kernel?

Thanks,
Leo Yan

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/5] Convert to use devm_*() for amba attached modules Leo Yan <leo.yan@linaro.org> - 2017-03-26 16:50 +0200
  Re: [PATCH 0/5] Convert to use devm_*() for amba attached modules Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2017-03-26 17:30 +0200
    Re: [PATCH 0/5] Convert to use devm_*() for amba attached modules Leo Yan <leo.yan@linaro.org> - 2017-03-26 17:50 +0200

csiph-web