Re: [PATCH v4] tpm_crb: request and relinquish locality 0

From	Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v4] tpm_crb: request and relinquish locality 0
Date	2017-03-26 14:10 +0200
Message-ID	<tpf9D-88R-3@gated-at.bofh.it> (permalink)
References	<touu5-8u8-9@gated-at.bofh.it> <toC8k-5sk-71@gated-at.bofh.it> <tp00V-5xt-1@gated-at.bofh.it>
Organization	Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo

Show all headers | View raw

On Sat, Mar 25, 2017 at 09:52:11PM +0200, Jarkko Sakkinen wrote:
> On Fri, Mar 24, 2017 at 11:25:57AM -0700, Jerry Snitselaar wrote:
> > 
> > Jarkko Sakkinen @ 2017-03-24 10:10 GMT:
> > 
> > > This commit adds support for requesting and relinquishing locality 0 in
> > > tpm_crb for the course of command transmission.
> > >
> > > In order to achieve this, two new callbacks are added to struct
> > > tpm_class_ops:
> > >
> > > - request_locality
> > > - relinquish_locality
> > >
> > > With CRB interface you first set either requestAccess or relinquish bit
> > > from TPM_LOC_CTRL_x register and then wait for locAssigned and
> > > tpmRegValidSts bits to be set in the TPM_LOC_STATE_x register.
> > >
> > > The reason why were are doing this is to make sure that the driver
> > > will work properly with Intel TXT that uses locality 2. There's no
> > > explicit guarantee that it would relinquish this locality. In more
> > > general sense this commit enables tpm_crb to be a well behaving
> > > citizen in a multi locality environment.
> > >
> > > Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
> > 
> > Reviewed-by: Jerry Snitselaar <jsnitsel@redhat.com>
> > Tested-by: Jerry Snitselaar <jsnitsel@redhat.com>
> > 
> > Tested on kabylake system that was hitting issues with earlier
> > iteration. Still don't have platform to test it dealing with
> > multi-locality enviroment.
> 
> I believe Jimmy (Gang Wei) has done such testing. Jimmy can you confirm
> and possibly do re-test (there's a locality branch in my tree to ease
> the testing) so that we could land this one?
> 
> /Jarkko

I applied this to my master and next branches.

/Jarkko

Thread

[PATCH v4] tpm_crb: request and relinquish locality 0 Jarkko Sakkinen <jarkko.sakkinen@iki.fi> - 2017-03-24 11:20 +0100
  Re: [PATCH v4] tpm_crb: request and relinquish locality 0 Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2017-03-24 11:20 +0100
    Re: [PATCH v4] tpm_crb: request and relinquish locality 0 Jerry Snitselaar <jsnitsel@redhat.com> - 2017-03-25 13:30 +0100
      Re: [PATCH v4] tpm_crb: request and relinquish locality 0 Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2017-03-25 21:00 +0100
  Re: [PATCH v4] tpm_crb: request and relinquish locality 0 Jerry Snitselaar <jsnitsel@redhat.com> - 2017-03-24 19:30 +0100
    Re: [PATCH v4] tpm_crb: request and relinquish locality 0 Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2017-03-25 21:00 +0100
      Re: [PATCH v4] tpm_crb: request and relinquish locality 0 Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2017-03-26 14:10 +0200
        Re: [PATCH v4] tpm_crb: request and relinquish locality 0 Jerry Snitselaar <jsnitsel@redhat.com> - 2017-03-26 18:50 +0200
          Re: [PATCH v4] tpm_crb: request and relinquish locality 0 Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2017-03-26 22:00 +0200
            Re: [PATCH v4] tpm_crb: request and relinquish locality 0 Jerry Snitselaar <jsnitsel@redhat.com> - 2017-03-27 01:00 +0200
              Re: [PATCH v4] tpm_crb: request and relinquish locality 0 Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2017-03-27 07:20 +0200

csiph-web