Re: [RFC PATCH 2/5] sched/events: Introduce cfs_rq load tracking trace event

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!news.servidellagleba.it!bofh.it!news.nic.it!robomod
From	Dietmar Eggemann <dietmar.eggemann@arm.com>
Newsgroups	linux.kernel
Subject	Re: [RFC PATCH 2/5] sched/events: Introduce cfs_rq load tracking trace event
Date	Tue, 28 Mar 2017 15:40:03 +0200
Message-ID	<tpZvR-8gn-61@gated-at.bofh.it> (permalink)
References	<tpSXo-3CJ-11@gated-at.bofh.it> <tpSXo-3CJ-9@gated-at.bofh.it> <tpUcO-4ow-15@gated-at.bofh.it>
X-Original-To	Peter Zijlstra <peterz@infradead.org>
User-Agent	Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0
MIME-Version	1.0
Content-Type	text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding	7bit
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	25
Organization	linux.* mail to news gateway
X-Original-Cc	Ingo Molnar <mingo@kernel.org>, LKML <linux-kernel@vger.kernel.org>, Matt Fleming <matt@codeblueprint.co.uk>, Vincent Guittot <vincent.guittot@linaro.org>, Steven Rostedt <rostedt@goodmis.org>, Morten Rasmussen <morten.rasmussen@arm.com>, Juri Lelli <juri.lelli@arm.com>, Patrick Bellasi <patrick.bellasi@arm.com>
X-Original-Date	Tue, 28 Mar 2017 15:30:41 +0200
X-Original-Message-ID	<cdf8bc6b-5ee8-0d15-1e50-a7cdbe9210a1@arm.com>
X-Original-References	<20170328063541.12912-1-dietmar.eggemann@arm.com> <20170328063541.12912-3-dietmar.eggemann@arm.com> <20170328075622.ywdm6rh75zmhv3id@hirez.programming.kicks-ass.net>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1610914

Show key headers only | View raw

On 03/28/2017 09:56 AM, Peter Zijlstra wrote:
> On Tue, Mar 28, 2017 at 07:35:38AM +0100, Dietmar Eggemann wrote:

[...]

>>  (1) a root task_group:
>>
>>      cpu=4 path=/ id=1 load=6 util=331
>
> What's @id and why do we care?

It's a per cgroup/subsystem unique id for every task_group (cpu controller):

struct task_group {
	struct cgroup_subsys_state css {
		...
		int id;
                 ...
	}
	...
}

The root task group path=/ has id=1 and all autogroups have id=0.

I agree, this id is redundant in case we have the task_group path.

Thread

[RFC PATCH 2/5] sched/events: Introduce cfs_rq load tracking trace event Dietmar Eggemann <dietmar.eggemann@arm.com> - 2017-03-28 08:40 +0200
  Re: [RFC PATCH 2/5] sched/events: Introduce cfs_rq load tracking  trace event Peter Zijlstra <peterz@infradead.org> - 2017-03-28 10:00 +0200
    Re: [RFC PATCH 2/5] sched/events: Introduce cfs_rq load tracking  trace event Dietmar Eggemann <dietmar.eggemann@arm.com> - 2017-03-28 15:40 +0200
  Re: [RFC PATCH 2/5] sched/events: Introduce cfs_rq load tracking  trace event Peter Zijlstra <peterz@infradead.org> - 2017-03-28 10:10 +0200
    Re: [RFC PATCH 2/5] sched/events: Introduce cfs_rq load tracking  trace event Steven Rostedt <rostedt@goodmis.org> - 2017-03-28 16:50 +0200
  Re: [RFC PATCH 2/5] sched/events: Introduce cfs_rq load tracking  trace event Steven Rostedt <rostedt@goodmis.org> - 2017-03-28 16:50 +0200
    Re: [RFC PATCH 2/5] sched/events: Introduce cfs_rq load tracking  trace event Peter Zijlstra <peterz@infradead.org> - 2017-03-28 18:50 +0200
      Re: [RFC PATCH 2/5] sched/events: Introduce cfs_rq load tracking  trace event Peter Zijlstra <peterz@infradead.org> - 2017-03-28 19:10 +0200
        Re: [RFC PATCH 2/5] sched/events: Introduce cfs_rq load tracking  trace event Patrick Bellasi <patrick.bellasi@arm.com> - 2017-03-28 19:30 +0200
          Re: [RFC PATCH 2/5] sched/events: Introduce cfs_rq load tracking  trace event Peter Zijlstra <peterz@infradead.org> - 2017-03-28 20:20 +0200
      Re: [RFC PATCH 2/5] sched/events: Introduce cfs_rq load tracking  trace event Steven Rostedt <rostedt@goodmis.org> - 2017-03-28 19:50 +0200
        Re: [RFC PATCH 2/5] sched/events: Introduce cfs_rq load tracking  trace event Steven Rostedt <rostedt@goodmis.org> - 2017-03-28 19:50 +0200
          Re: [RFC PATCH 2/5] sched/events: Introduce cfs_rq load tracking  trace event Dietmar Eggemann <dietmar.eggemann@arm.com> - 2017-03-29 22:50 +0200
      Re: [RFC PATCH 2/5] sched/events: Introduce cfs_rq load tracking  trace event Dietmar Eggemann <dietmar.eggemann@arm.com> - 2017-03-29 23:10 +0200
        Re: [RFC PATCH 2/5] sched/events: Introduce cfs_rq load tracking  trace event Peter Zijlstra <peterz@infradead.org> - 2017-03-30 09:10 +0200
          Re: [RFC PATCH 2/5] sched/events: Introduce cfs_rq load tracking  trace event Dietmar Eggemann <dietmar.eggemann@arm.com> - 2017-03-30 09:50 +0200

csiph-web