Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1610975

Re: [PATCH v2] usb: phy: isp1301: Add OF device ID table

Path csiph.com!goblin3!goblin.stu.neva.ru!news.neodome.net!news.redatomik.org!aioe.org!news.servidellagleba.it!bofh.it!news.nic.it!robomod
From Felipe Balbi <balbi@kernel.org>
Newsgroups linux.kernel
Subject Re: [PATCH v2] usb: phy: isp1301: Add OF device ID table
Date Tue, 28 Mar 2017 16:00:04 +0200
Message-ID <tpZPd-8sh-27@gated-at.bofh.it> (permalink)
References <tl86J-1Jb-1@gated-at.bofh.it>
X-Extloop1 1
X-Ironport-Av E=Sophos;i="5.36,236,1486454400"; d="scan'208";a="1112941146"
MIME-Version 1.0
Content-Type text/plain
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 19
Organization linux.* mail to news gateway
X-Original-Cc Javier Martinez Canillas <javier@osg.samsung.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, linux-usb@vger.kernel.org
X-Original-Date Tue, 28 Mar 2017 16:45:26 +0300
X-Original-Message-ID <87wpb9frbd.fsf@linux.intel.com>
X-Original-References <20170315034646.10360-1-javier@osg.samsung.com>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1610975

Show key headers only | View raw


Hi,

Javier Martinez Canillas <javier@osg.samsung.com> writes:
> The driver doesn't have a struct of_device_id table but supported devices
> are registered via Device Trees. This is working on the assumption that a
> I2C device registered via OF will always match a legacy I2C device ID and
> that the MODALIAS reported will always be of the form i2c:<device>.
>
> But this could change in the future so the correct approach is to have an
> OF device ID table if the devices are registered via OF.
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>

this is already upstream. Care to send an incremental diff in case we
need this fixed further?

-- 
balbi

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

Re: [PATCH v2] usb: phy: isp1301: Add OF device ID table Felipe Balbi <balbi@kernel.org> - 2017-03-28 16:00 +0200

csiph-web