Re: [PATCH] 6lowpan: set peer_addr correctly again

From	"Von Dentz, Luiz" <luiz.von.dentz@intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] 6lowpan: set peer_addr correctly again
Date	2017-03-28 15:50 +0200
Message-ID	<tpZFx-8kZ-47@gated-at.bofh.it> (permalink)
References	<tpZvP-8gn-5@gated-at.bofh.it> <tpZvR-8gn-63@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Marcel,

On Tue, Mar 28, 2017 at 4:37 PM, Marcel Holtmann <marcel@holtmann.org> wrote:
> Hi Arnd,
>
>> A bugfix accidentally changed one line to return the peer_addr
>> from setup_header, causing it to become unused:
>>
>> net/bluetooth/6lowpan.c: In function 'setup_header':
>> net/bluetooth/6lowpan.c:402:14: error: parameter 'peer_addr' set but not used [-Werror=unused-but-set-parameter]
>>
>> The only user of the variable is a subsequent printk(), and
>> it is not otherwise initialized, so reverting the changed line
>> looks like the right fix.
>>
>> Fixes: fb6f2f606ce8 ("6lowpan: Fix IID format for Bluetooth")
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>> ---
>> net/bluetooth/6lowpan.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> I took Colin’s patch since it showed up first in my inbox.

Thanks, I might be missing something since the error doesn't show up for me:

  CC [M]  net/bluetooth/6lowpan.o
  LD [M]  net/bluetooth/bluetooth_6lowpan.o

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] 6lowpan: set peer_addr correctly again Arnd Bergmann <arnd@arndb.de> - 2017-03-28 15:40 +0200
  Re: [PATCH] 6lowpan: set peer_addr correctly again Marcel Holtmann <marcel@holtmann.org> - 2017-03-28 15:40 +0200
    Re: [PATCH] 6lowpan: set peer_addr correctly again "Von Dentz, Luiz" <luiz.von.dentz@intel.com> - 2017-03-28 15:50 +0200

csiph-web