Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1610506

[PATCH] [net-next] stmmac: use netif_set_real_num_{rx,tx}_queues

Show all headers | View raw

A driver must not access the two fields directly but should instead use
the helper functions to set the values and keep a consistent internal
state:

ethernet/stmicro/stmmac/stmmac_main.c: In function 'stmmac_dvr_probe':
ethernet/stmicro/stmmac/stmmac_main.c:4083:8: error: 'struct net_device' has no member named 'real_num_rx_queues'; did you mean 'real_num_tx_queues'?

Fixes: a8f5102af2a7 ("net: stmmac: TX and RX queue priority configuration")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
index c78f444ad423..fe1d9592956f 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
@@ -4080,8 +4080,8 @@ int stmmac_dvr_probe(struct device *device,
 		goto error_hw_init;
 
 	/* Configure real RX and TX queues */
-	ndev->real_num_rx_queues = priv->plat->rx_queues_to_use;
-	ndev->real_num_tx_queues = priv->plat->tx_queues_to_use;
+	netif_set_real_num_rx_queues(ndev, priv->plat->rx_queues_to_use);
+	netif_set_real_num_tx_queues(ndev, priv->plat->tx_queues_to_use);
 
 	priv->dma_buf_sz = STMMAC_ALIGN(buf_sz);
 
-- 
2.9.0

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] [net-next] stmmac: use netif_set_real_num_{rx,tx}_queues Arnd Bergmann <arnd@arndb.de> - 2017-03-28 12:00 +0200
  Re: [PATCH] [net-next] stmmac: use  netif_set_real_num_{rx,tx}_queues David Miller <davem@davemloft.net> - 2017-03-29 03:10 +0200
    Re: [PATCH] [net-next] stmmac: use netif_set_real_num_{rx,tx}_queues Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-03-30 09:50 +0200
      Re: [PATCH] [net-next] stmmac: use netif_set_real_num_{rx,tx}_queues Thierry Reding <treding@nvidia.com> - 2017-03-30 16:40 +0200
        Re: Re: [PATCH] [net-next] stmmac: use  netif_set_real_num_{rx,tx}_queues Niklas Cassel <niklas.cassel@axis.com> - 2017-03-30 18:40 +0200
          Re: [PATCH] [net-next] stmmac: use netif_set_real_num_{rx,tx}_queues Joao Pinto <Joao.Pinto@synopsys.com> - 2017-03-30 18:50 +0200
            Re: [PATCH] [net-next] stmmac: use netif_set_real_num_{rx,tx}_queues Giuseppe CAVALLARO <peppe.cavallaro@st.com> - 2017-04-03 15:10 +0200
              Re: [PATCH] [net-next] stmmac: use netif_set_real_num_{rx,tx}_queues Joao Pinto <Joao.Pinto@synopsys.com> - 2017-04-03 15:20 +0200
                Re: [PATCH] [net-next] stmmac: use netif_set_real_num_{rx,tx}_queues Giuseppe CAVALLARO <peppe.cavallaro@st.com> - 2017-04-04 08:20 +0200
        Re: [PATCH] [net-next] stmmac: use  netif_set_real_num_{rx,tx}_queues David Miller <davem@davemloft.net> - 2017-03-30 20:00 +0200
          Re: [PATCH] [net-next] stmmac: use netif_set_real_num_{rx,tx}_queues Joao Pinto <Joao.Pinto@synopsys.com> - 2017-03-31 12:20 +0200
            Re: [PATCH] [net-next] stmmac: use netif_set_real_num_{rx,tx}_queues Joao Pinto <Joao.Pinto@synopsys.com> - 2017-03-31 12:50 +0200
              Re: [PATCH] [net-next] stmmac: use  netif_set_real_num_{rx,tx}_queues David Miller <davem@davemloft.net> - 2017-03-31 19:00 +0200
                Re: [PATCH] [net-next] stmmac: use netif_set_real_num_{rx,tx}_queues Joao Pinto <Joao.Pinto@synopsys.com> - 2017-03-31 19:00 +0200

csiph-web