Re: [PATCH v2 8/9] gpio: 104-idio-16: make use of raw_spinlock variants

From	Linus Walleij <linus.walleij@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 8/9] gpio: 104-idio-16: make use of raw_spinlock variants
Date	2017-03-28 11:20 +0200
Message-ID	<tpVse-5pw-17@gated-at.bofh.it> (permalink)
References	<tnALf-1nk-5@gated-at.bofh.it> <tnBHj-216-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Mar 21, 2017 at 11:43 PM, Julia Cartwright <julia@ni.com> wrote:

> The 104-idio-16 gpio driver currently implements an irq_chip for handling
> interrupts; due to how irq_chip handling is done, it's necessary for the
> irq_chip methods to be invoked from hardirq context, even on a a
> real-time kernel.  Because the spinlock_t type becomes a "sleeping"
> spinlock w/ RT kernels, it is not suitable to be used with irq_chips.
>
> A quick audit of the operations under the lock reveal that they do only
> minimal, bounded work, and are therefore safe to do under a raw spinlock.
>
> Signed-off-by: Julia Cartwright <julia@ni.com>
> ---
> New patch as of v2 of series.

Patch applied to the GPIO tree with William's ACK.

Yours,
Linus Walleij

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 8/9] gpio: 104-idio-16: make use of raw_spinlock variants Julia Cartwright <julia@ni.com> - 2017-03-22 00:50 +0100
  Re: [PATCH v2 8/9] gpio: 104-idio-16: make use of raw_spinlock  variants William Breathitt Gray <vilhelm.gray@gmail.com> - 2017-03-22 13:50 +0100
  Re: [PATCH v2 8/9] gpio: 104-idio-16: make use of raw_spinlock variants Linus Walleij <linus.walleij@linaro.org> - 2017-03-28 11:20 +0200

csiph-web