Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1610468

Re: [alsa-devel] [PATCH v3 2/2] ASoC: imx-wm8962: Fix codec_clk cleanup

Show all headers | View raw

On Tue, Mar 28, 2017 at 11:58:52AM +0300, Daniel Baluta wrote:
> Resource managed devm_clk_get only works with platform's device dev.
> 

I feel like this could use an explaination of why not using devm
is the correct fix, rather than just using the platform device
for the call. Its not obvious to me, that using the platform
device would be an issue.

Thanks,
Charles

> Reported-by: Nicolin Chen <nicoleotsuka@gmail.com>
> Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com>
> ---
>  sound/soc/fsl/imx-wm8962.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/sound/soc/fsl/imx-wm8962.c b/sound/soc/fsl/imx-wm8962.c
> index 3d894d9..52659fa 100644
> --- a/sound/soc/fsl/imx-wm8962.c
> +++ b/sound/soc/fsl/imx-wm8962.c
> @@ -231,7 +231,7 @@ static int imx_wm8962_probe(struct platform_device *pdev)
>  		goto fail;
>  	}
>  
> -	codec_clk = devm_clk_get(&codec_dev->dev, NULL);
> +	codec_clk = clk_get(&codec_dev->dev, NULL);
>  	if (IS_ERR(codec_clk)) {
>  		ret = PTR_ERR(codec_clk);
>  		dev_err(&codec_dev->dev, "failed to get codec clk: %d\n", ret);
> @@ -239,6 +239,7 @@ static int imx_wm8962_probe(struct platform_device *pdev)
>  	}
>  
>  	data->clk_frequency = clk_get_rate(codec_clk);
> +	clk_put(codec_clk);
>  
>  	data->dai.name = "HiFi";
>  	data->dai.stream_name = "HiFi";
> -- 
> 2.7.4
> 
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [alsa-devel] [PATCH v3 2/2] ASoC: imx-wm8962: Fix codec_clk  cleanup Charles Keepax <ckeepax@opensource.wolfsonmicro.com> - 2017-03-28 11:30 +0200
  Re: [alsa-devel] [PATCH v3 2/2] ASoC: imx-wm8962: Fix codec_clk cleanup Daniel Baluta <daniel.baluta@gmail.com> - 2017-03-28 12:50 +0200
    Re: [alsa-devel] [PATCH v3 2/2] ASoC: imx-wm8962: Fix codec_clk  cleanup Charles Keepax <ckeepax@opensource.wolfsonmicro.com> - 2017-03-28 14:00 +0200
      Re: [alsa-devel] [PATCH v3 2/2] ASoC: imx-wm8962: Fix codec_clk  cleanup Mark Brown <broonie@kernel.org> - 2017-03-28 17:30 +0200
        Re: [alsa-devel] [PATCH v3 2/2] ASoC: imx-wm8962: Fix codec_clk  cleanup Charles Keepax <ckeepax@opensource.wolfsonmicro.com> - 2017-03-28 17:50 +0200
        Re: [alsa-devel] [PATCH v3 2/2] ASoC: imx-wm8962: Fix codec_clk cleanup Daniel Baluta <daniel.baluta@gmail.com> - 2017-03-29 13:40 +0200
          Re: [alsa-devel] [PATCH v3 2/2] ASoC: imx-wm8962: Fix codec_clk  cleanup Mark Brown <broonie@kernel.org> - 2017-03-29 14:00 +0200

csiph-web