[tip:perf/core] perf utils: use sizeof(buf) - 1 in readlink() call

Path	csiph.com!goblin1!goblin.stu.neva.ru!feeders.as203319.net!feeder02.as203319.net!aioe.org!bofh.it!news.nic.it!robomod
From	tip-bot for Tommi Rantala <tipbot@zytor.com>
Newsgroups	linux.kernel
Subject	[tip:perf/core] perf utils: use sizeof(buf) - 1 in readlink() call
Date	Tue, 28 Mar 2017 08:10:02 +0200
Message-ID	<tpSum-3pJ-19@gated-at.bofh.it> (permalink)
References	<tpSum-3pJ-21@gated-at.bofh.it>
Reply-To	peterz@infradead.org, alexander.shishkin@linux.intel.com, hpa@zytor.com, tommi.t.rantala@nokia.com, tglx@linutronix.de, mingo@kernel.org, acme@redhat.com, linux-kernel@vger.kernel.org
Git-Commit-ID	b7126ef78612a3d4a37aadf39125cff048cebb9b
X-Mailer	tip-git-log-daemon
Robot-ID	<tip-bot.git.kernel.org>
Robot-Unsubscribe	Contact <mailto:hpa@kernel.org> to get blacklisted from these emails
MIME-Version	1.0
Content-Transfer-Encoding	8bit
Content-Type	text/plain; charset=UTF-8
Content-Disposition	inline
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	33
Organization	linux.* mail to news gateway
X-Original-Cc	mingo@kernel.org, acme@redhat.com, tglx@linutronix.de, linux-kernel@vger.kernel.org, peterz@infradead.org, alexander.shishkin@linux.intel.com, tommi.t.rantala@nokia.com, hpa@zytor.com
X-Original-Date	Mon, 27 Mar 2017 22:58:00 -0700
X-Original-Message-ID	<tip-b7126ef78612a3d4a37aadf39125cff048cebb9b@git.kernel.org>
X-Original-References	<20170322130624.21881-5-tommi.t.rantala@nokia.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1610346

Show key headers only | View raw

Commit-ID:  b7126ef78612a3d4a37aadf39125cff048cebb9b
Gitweb:     http://git.kernel.org/tip/b7126ef78612a3d4a37aadf39125cff048cebb9b
Author:     Tommi Rantala <tommi.t.rantala@nokia.com>
AuthorDate: Wed, 22 Mar 2017 15:06:22 +0200
Committer:  Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Mon, 27 Mar 2017 15:36:27 -0300

perf utils: use sizeof(buf) - 1 in readlink() call

Ensure that we have space for the null byte in buf.

Signed-off-by: Tommi Rantala <tommi.t.rantala@nokia.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/20170322130624.21881-5-tommi.t.rantala@nokia.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/util/header.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/util/header.c b/tools/perf/util/header.c
index 05714d5..cf22962 100644
--- a/tools/perf/util/header.c
+++ b/tools/perf/util/header.c
@@ -378,7 +378,7 @@ static int write_cmdline(int fd, struct perf_header *h __maybe_unused,
 	 * actual atual path to perf binary
 	 */
 	sprintf(proc, "/proc/%d/exe", getpid());
-	ret = readlink(proc, buf, sizeof(buf));
+	ret = readlink(proc, buf, sizeof(buf) - 1);
 	if (ret <= 0)
 		return -1;

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[tip:perf/core] perf utils: use sizeof(buf) - 1 in readlink() call tip-bot for Tommi Rantala <tipbot@zytor.com> - 2017-03-28 08:10 +0200

csiph-web