RE: [tpmdd-devel] [PATCH] tpm/tpm_crb: fix unused warnings on suspend/resume functions

Path	csiph.com!news.redatomik.org!aioe.org!bofh.it!news.nic.it!robomod
From	"Winkler, Tomas" <tomas.winkler@intel.com>
Newsgroups	linux.kernel
Subject	RE: [tpmdd-devel] [PATCH] tpm/tpm_crb: fix unused warnings on suspend/resume functions
Date	Tue, 28 Mar 2017 08:20:02 +0200
Message-ID	<tpSE2-3sW-11@gated-at.bofh.it> (permalink)
References	<tnn1E-xY-17@gated-at.bofh.it> <tnn1E-xY-15@gated-at.bofh.it> <tnA8x-18H-3@gated-at.bofh.it> <todjA-4ib-29@gated-at.bofh.it>
X-Original-To	Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Dkim-Signature	v=1; a=rsa-sha256; c=simple/simple; d=intel.com; i=@intel.com; q=dns/txt; s=intel; t=1490681761; x=1522217761; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=u1ZH0/Tk9M59UUOYUxLXZ13k1hpmJq9n9C7DoXYxsMk=; b=WyUDJyGSvw6Aw9ejcjC40RLEW22Q8qzubtBAwk41+y3cw9DoXDcpQR/5 yJppsCf4B9cvU1/ehpPftgMBJI6hjg==;
X-Extloop1	1
X-Ironport-Av	E=Sophos;i="5.36,235,1486454400"; d="scan'208";a="1112830515"
Thread-Topic	[tpmdd-devel] [PATCH] tpm/tpm_crb: fix unused warnings on suspend/resume functions
Thread-Index	AQHSohnfDtyghRJoPUGP3C4BcBhF+KGf2daAgAKbDICAB1xD4A==
Accept-Language	en-US
Content-Language	en-US
X-Ctpclassification	CTP_IC
X-Titus-Metadata-40	eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNGVhYWU4NTMtN2U0Zi00YWI5LWFhYjEtNDZlMTZiMTE2YjViIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6Ikg5NzY5MFNJWVJqSWc4Yjc5R2VNQk1zMFJTR2tPOVhoNDV6SlBjSW5IRlE9In0=
X-Originating-IP	[10.184.70.10]
Content-Type	text/plain; charset="utf-8"
Content-Transfer-Encoding	base64
MIME-Version	1.0
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	27
Organization	linux.* mail to news gateway
X-Original-Cc	Jérémy Lefaure <jeremy.lefaure@lse.epita.fr>, "tpmdd-devel@lists.sourceforge.net" <tpmdd-devel@lists.sourceforge.net>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "arnd@arndb.de" <arnd@arndb.de>
X-Original-Date	Tue, 28 Mar 2017 06:15:56 +0000
X-Original-Message-ID	<5B8DA87D05A7694D9FA63FD143655C1B543C8D91@hasmsx108.ger.corp.intel.com>
X-Original-References	<20170317015133.2269-1-jeremy.lefaure@lse.epita.fr> <20170321080353.oh2apppp37nchuw7@intel.com> <5B8DA87D05A7694D9FA63FD143655C1B543B122D@hasmsx108.ger.corp.intel.com> <20170323155117.w6zsewdxc6eeti4b@intel.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1610356

Show key headers only | View raw


> 
> On Tue, Mar 21, 2017 at 10:05:36PM +0000, Winkler, Tomas wrote:
> > > On Thu, Mar 16, 2017 at 09:51:33PM -0400, Jérémy Lefaure wrote:
> > > > When PM_SLEEP is disabled crb_pm_suspend and crb_pm_resume are
> not
> > > > used by SET_SYSTEM_SLEEP_PM_OPS even if PM is enabled:
> > > >
> > > > drvers/char/tpm/tpm_crb.c:540:12: warning: ‘crb_pm_suspend’
> > > > defined but not used [-Wunused-function]  static int
> > > > crb_pm_suspend(struct device *dev)
> > > >             ^
> > > > drivers/char/tpm/tpm_crb.c:551:12: warning: ‘crb_pm_resume’
> > > > defined but not used [-Wunused-function]  static int
> > > > crb_pm_resume(struct device *dev)
> > > >             ^
> > > >
> > > > The preprocessor condition should be on CONFIG_PM_SLEEP, not on
> > > CONFIG_PM.
> > > > However, this patch fixes this warning by using __maybe_unused on
> > > > function that are in the preprocessor condition.
> > > >
> > > > Signed-off-by: Jérémy Lefaure <jeremy.lefaure@lse.epita.fr>
> > >
> > > Thanks. Please include also linux-kernel@vger.kernel.org in the future.
> > >
> > > Reviewed-by: Jarkko Saskkinen <jarkko.sakkinen@linux.intel.com>
> >
> > We should go with Arnd's patch, which is actually the same,  but it
> > was already reviewed and has better commit messages.
> > Thanks
> > Tomas
> 
> You are right about the commit message but where are the Reviewed-by tags?

Please add mine.

> [1]
> 
> [1] https://patchwork.kernel.org/patch/9633537/
> 
Tomas

Thread

Re: [PATCH] tpm/tpm_crb: fix unused warnings on suspend/resume  functions Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2017-03-21 09:10 +0100
  RE: [tpmdd-devel] [PATCH] tpm/tpm_crb: fix unused warnings on  suspend/resume functions "Winkler, Tomas" <tomas.winkler@intel.com> - 2017-03-21 23:10 +0100
    Re: [tpmdd-devel] [PATCH] tpm/tpm_crb: fix unused warnings on  suspend/resume functions Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2017-03-23 17:00 +0100
      RE: [tpmdd-devel] [PATCH] tpm/tpm_crb: fix unused warnings on  suspend/resume functions "Winkler, Tomas" <tomas.winkler@intel.com> - 2017-03-28 08:20 +0200
        Re: [tpmdd-devel] [PATCH] tpm/tpm_crb: fix unused warnings on  suspend/resume functions Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2017-03-28 09:40 +0200

csiph-web