Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1610273

Re: [PATCH] selftests: gpio: fix Makefile

From Michael Ellerman <mpe@ellerman.id.au>
Newsgroups linux.kernel
Subject Re: [PATCH] selftests: gpio: fix Makefile
Date 2017-03-28 05:10 +0200
Message-ID <tpPGa-1lb-7@gated-at.bofh.it> (permalink)
References <tow2S-10z-9@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Fathi Boudra <fathi.boudra@linaro.org> writes:
> diff --git a/tools/testing/selftests/gpio/Makefile b/tools/testing/selftests/gpio/Makefile
> index 205e4d10e085..714f1f7df04d 100644
> --- a/tools/testing/selftests/gpio/Makefile
> +++ b/tools/testing/selftests/gpio/Makefile
> @@ -1,23 +1,24 @@
> +CFLAGS += -O2 -g -std=gnu99 -Wall
> +CFLAGS += -I../../../../include/uapi/ -I../../../../include/

Those are kernel headers, they *might* work in userspace but they're not
designed to.

Use the exported headers:

CFLAGS += -I../../../../usr/include


If they're not there, then the user can install them, or fall back to
the system headers.

> +CFLAGS += $(shell pkg-config --cflags mount)
> +LDLIBS += $(shell pkg-config --libs mount)

What if pkg-config isn't installed?

cheers

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] selftests: gpio: fix Makefile Fathi Boudra <fathi.boudra@linaro.org> - 2017-03-24 13:00 +0100
  Re: [PATCH] selftests: gpio: fix Makefile Michael Ellerman <mpe@ellerman.id.au> - 2017-03-28 05:10 +0200
    Re: [PATCH] selftests: gpio: fix Makefile Fathi Boudra <fathi.boudra@linaro.org> - 2017-03-28 06:20 +0200

csiph-web