[PATCH 09/16] cpufreq: intel_pstate: Modify check in intel_pstate_update_status()

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	"Rafael J. Wysocki" <rjw@rjwysocki.net>
Newsgroups	linux.kernel
Subject	[PATCH 09/16] cpufreq: intel_pstate: Modify check in intel_pstate_update_status()
Date	Tue, 28 Mar 2017 00:50:03 +0200
Message-ID	<tpLCz-6Cv-29@gated-at.bofh.it> (permalink)
References	<tpLsR-6yQ-7@gated-at.bofh.it>
User-Agent	KMail/4.14.10 (Linux/4.10.0+; KDE/4.14.9; x86_64; ; )
MIME-Version	1.0
Content-Transfer-Encoding	7Bit
Content-Type	text/plain; charset="us-ascii"
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	26
Organization	linux.* mail to news gateway
X-Original-Cc	LKML <linux-kernel@vger.kernel.org>, Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>, Doug Smythies <dsmythies@telus.net>
X-Original-Date	Tue, 28 Mar 2017 00:14:08 +0200
X-Original-Message-ID	<3621003.tsN5tfAxs4@aspire.rjw.lan>
X-Original-References	<6409323.DYHvh3CYlO@aspire.rjw.lan>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1610143

Show key headers only | View raw

From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

One of the checks in intel_pstate_update_status() implicitly relies
on the information that there are only two struct cpufreq_driver
objects available, but it is better to do it directly against the
value it really is about (to make the code easier to follow if
nothing else).

Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
---
 drivers/cpufreq/intel_pstate.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux-pm/drivers/cpufreq/intel_pstate.c
===================================================================
--- linux-pm.orig/drivers/cpufreq/intel_pstate.c
+++ linux-pm/drivers/cpufreq/intel_pstate.c
@@ -2345,7 +2345,7 @@ static int intel_pstate_update_status(co
 
 	if (size == 7 && !strncmp(buf, "passive", size)) {
 		if (intel_pstate_driver) {
-			if (intel_pstate_driver != &intel_pstate)
+			if (intel_pstate_driver == &intel_cpufreq)
 				return 0;
 
 			ret = intel_pstate_unregister_driver();

Thread

[PATCH 00/16] cpufreq: intel_pstate: Cleanups and optimizations "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2017-03-28 00:50 +0200
  [PATCH 02/16] cpufreq: intel_pstate: Drop pointless initialization of PID parameters "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2017-03-28 00:50 +0200
  [PATCH 13/16] cpufreq: intel_pstate: Drop struct cpu_defaults "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2017-03-28 00:50 +0200
  [PATCH 10/16] cpufreq: intel_pstate: Use different utilization update callbacks "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2017-03-28 00:50 +0200
  [PATCH 14/16] cpufreq: intel_pstate: Introduce pid_in_use() "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2017-03-28 00:50 +0200
  [PATCH 08/16] cpufreq: intel_pstate: Drop driver_registered variable "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2017-03-28 00:50 +0200
  [PATCH 03/16] cpufreq: intel_pstate: Initialize pid_params statically "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2017-03-28 00:50 +0200
  [PATCH 06/16] cpufreq: intel_pstate: Set HWP sampling interval once "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2017-03-28 00:50 +0200
  [PATCH 05/16] cpufreq: intel_pstate: Clean up intel_pstate_busy_pid_reset() "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2017-03-28 00:50 +0200
  [PATCH 11/16] cpufreq: intel_pstate: Add update_util callback to pstate_funcs "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2017-03-28 00:50 +0200
  [PATCH 09/16] cpufreq: intel_pstate: Modify check in intel_pstate_update_status() "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2017-03-28 00:50 +0200
  [PATCH 01/16] cpufreq: intel_pstate: Eliminate struct perf_limits "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2017-03-28 00:50 +0200

csiph-web