Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1610137
| Path | csiph.com!aioe.org!bofh.it!news.nic.it!robomod |
|---|---|
| From | "Rafael J. Wysocki" <rjw@rjwysocki.net> |
| Newsgroups | linux.kernel |
| Subject | [PATCH 14/16] cpufreq: intel_pstate: Introduce pid_in_use() |
| Date | Tue, 28 Mar 2017 00:50:02 +0200 |
| Message-ID | <tpLCy-6Cv-15@gated-at.bofh.it> (permalink) |
| References | <tpLsR-6yQ-7@gated-at.bofh.it> |
| X-Original-To | Linux PM <linux-pm@vger.kernel.org> |
| User-Agent | KMail/4.14.10 (Linux/4.10.0+; KDE/4.14.9; x86_64; ; ) |
| MIME-Version | 1.0 |
| Content-Transfer-Encoding | 7Bit |
| Content-Type | text/plain; charset="us-ascii" |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 68 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | LKML <linux-kernel@vger.kernel.org>, Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>, Doug Smythies <dsmythies@telus.net> |
| X-Original-Date | Tue, 28 Mar 2017 00:20:13 +0200 |
| X-Original-Message-ID | <4743907.FnUvY4AAjW@aspire.rjw.lan> |
| X-Original-References | <6409323.DYHvh3CYlO@aspire.rjw.lan> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1610137 |
Show key headers only | View raw
From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Add a new function pid_in_use() to return the information on whether
or not the PID-based P-state selection algorithm is in use.
That allows a couple of complicated conditions in the code to be
reduced to simple checks against the new function's return value.
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
---
drivers/cpufreq/intel_pstate.c | 16 +++++++++++-----
1 file changed, 11 insertions(+), 5 deletions(-)
Index: linux-pm/drivers/cpufreq/intel_pstate.c
===================================================================
--- linux-pm.orig/drivers/cpufreq/intel_pstate.c
+++ linux-pm/drivers/cpufreq/intel_pstate.c
@@ -1893,6 +1893,8 @@ static const struct x86_cpu_id intel_pst
{}
};
+static bool pid_in_use(void);
+
static int intel_pstate_init_cpu(unsigned int cpunum)
{
struct cpudata *cpu;
@@ -1923,7 +1925,7 @@ static int intel_pstate_init_cpu(unsigne
intel_pstate_disable_ee(cpunum);
intel_pstate_hwp_enable(cpu);
- } else if (pstate_funcs.update_util == intel_pstate_update_util_pid) {
+ } else if (pid_in_use()) {
intel_pstate_pid_reset(cpu);
}
@@ -2269,6 +2271,12 @@ static struct cpufreq_driver intel_cpufr
static struct cpufreq_driver *default_driver = &intel_pstate;
+static bool pid_in_use(void)
+{
+ return intel_pstate_driver == &intel_pstate &&
+ pstate_funcs.update_util == intel_pstate_update_util_pid;
+}
+
static void intel_pstate_driver_cleanup(void)
{
unsigned int cpu;
@@ -2303,8 +2311,7 @@ static int intel_pstate_register_driver(
global.min_perf_pct = min_perf_pct_min();
- if (intel_pstate_driver == &intel_pstate && !hwp_active &&
- pstate_funcs.update_util == intel_pstate_update_util_pid)
+ if (pid_in_use())
intel_pstate_debug_expose_params();
return 0;
@@ -2315,8 +2322,7 @@ static int intel_pstate_unregister_drive
if (hwp_active)
return -EBUSY;
- if (intel_pstate_driver == &intel_pstate &&
- pstate_funcs.update_util == intel_pstate_update_util_pid)
+ if (pid_in_use())
intel_pstate_debug_hide_params();
cpufreq_unregister_driver(intel_pstate_driver);
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 00/16] cpufreq: intel_pstate: Cleanups and optimizations "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2017-03-28 00:50 +0200 [PATCH 02/16] cpufreq: intel_pstate: Drop pointless initialization of PID parameters "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2017-03-28 00:50 +0200 [PATCH 13/16] cpufreq: intel_pstate: Drop struct cpu_defaults "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2017-03-28 00:50 +0200 [PATCH 10/16] cpufreq: intel_pstate: Use different utilization update callbacks "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2017-03-28 00:50 +0200 [PATCH 14/16] cpufreq: intel_pstate: Introduce pid_in_use() "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2017-03-28 00:50 +0200 [PATCH 08/16] cpufreq: intel_pstate: Drop driver_registered variable "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2017-03-28 00:50 +0200 [PATCH 03/16] cpufreq: intel_pstate: Initialize pid_params statically "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2017-03-28 00:50 +0200 [PATCH 06/16] cpufreq: intel_pstate: Set HWP sampling interval once "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2017-03-28 00:50 +0200 [PATCH 05/16] cpufreq: intel_pstate: Clean up intel_pstate_busy_pid_reset() "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2017-03-28 00:50 +0200 [PATCH 11/16] cpufreq: intel_pstate: Add update_util callback to pstate_funcs "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2017-03-28 00:50 +0200 [PATCH 09/16] cpufreq: intel_pstate: Modify check in intel_pstate_update_status() "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2017-03-28 00:50 +0200 [PATCH 01/16] cpufreq: intel_pstate: Eliminate struct perf_limits "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2017-03-28 00:50 +0200
csiph-web