Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1610002

Re: [PATCH v3] block: trace completion of all bios.

From Christoph Hellwig <hch@infradead.org>
Newsgroups linux.kernel
Subject Re: [PATCH v3] block: trace completion of all bios.
Date 2017-03-27 19:20 +0200
Message-ID <tpGtc-34b-11@gated-at.bofh.it> (permalink)
References (2 earlier) <to5Fp-7vn-33@gated-at.bofh.it> <to8tB-116-35@gated-at.bofh.it> <tokXM-1Dk-13@gated-at.bofh.it> <tpyOZ-5Ej-9@gated-at.bofh.it> <tpzBq-66r-57@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Mon, Mar 27, 2017 at 08:49:57PM +1100, NeilBrown wrote:
> On Mon, Mar 27 2017, Christoph Hellwig wrote:
> 
> > I don't really like the flag at all.  I'd much prefer a __bio_endio
> > with a 'bool trace' flag.  Also please remove the manual tracing in
> > dm.ċ.  Once that is done I suspect we can also remove the
> > block_bio_complete export.
> 
> Can you say why you don't like it?

It uses up a precious bit in the bio for something that should be state
that can be determined in the caller at compile time.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] block: trace completion of all bios. NeilBrown <neilb@suse.com> - 2017-03-22 03:40 +0100
  Re: [PATCH] block: trace completion of all bios. Christoph Hellwig <hch@infradead.org> - 2017-03-22 14:00 +0100
    Re: [PATCH] block: trace completion of all bios. NeilBrown <neilb@suse.com> - 2017-03-23 08:50 +0100
    [PATCH v2] block: trace completion of all bios. NeilBrown <neilb@suse.com> - 2017-03-23 08:50 +0100
      Re: [PATCH v2] block: trace completion of all bios. Ming Lei <tom.leiming@gmail.com> - 2017-03-23 11:50 +0100
        Re: [PATCH v2] block: trace completion of all bios. NeilBrown <neilb@suse.com> - 2017-03-24 01:10 +0100
        [PATCH v3] block: trace completion of all bios. NeilBrown <neilb@suse.com> - 2017-03-24 01:10 +0100
          Re: [PATCH v3] block: trace completion of all bios. Ming Lei <tom.leiming@gmail.com> - 2017-03-24 07:50 +0100
            Re: [PATCH v3] block: trace completion of all bios. NeilBrown <neilb@suse.com> - 2017-03-27 01:30 +0200
          Re: [PATCH v3] block: trace completion of all bios. Christoph Hellwig <hch@infradead.org> - 2017-03-27 11:10 +0200
            Re: [PATCH v3] block: trace completion of all bios. NeilBrown <neilb@suse.com> - 2017-03-27 12:00 +0200
              Re: [PATCH v3] block: trace completion of all bios. Christoph Hellwig <hch@infradead.org> - 2017-03-27 19:20 +0200
                Re: [dm-devel] [PATCH v3] block: trace completion of all bios. NeilBrown <neilb@suse.com> - 2017-03-28 01:50 +0200

csiph-web