scsi_debug: shared dev context, BUG or FEATURE?

From	Dmitry Monakhov <dmonakhov@openvz.org>
Newsgroups	linux.kernel
Subject	scsi_debug: shared dev context, BUG or FEATURE?
Date	2017-03-27 19:50 +0200
Message-ID	<tpGWd-3iR-9@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi scsi_debug has very strange structure
from one point it supports dynamic number of devices
but from other point context is common for all devices:
 - dif_storep (array of t10 dif tuples)
 - map_storep (block map for thinprovision)
 - fake_storep (in memory data storage)
 - sdebug_q_arr (queue array)
So basically we may have many devices with single context which refers
common data. Are any sane reason to share context between devices?
Who use such behaviour?

IMHO this is a pure bug. Please correct me if I'm wrong, I'll plan to
fix that by allocation separate context for each dev.

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

scsi_debug: shared dev context, BUG or FEATURE? Dmitry Monakhov <dmonakhov@openvz.org> - 2017-03-27 19:50 +0200
  Re: scsi_debug: shared dev context, BUG or FEATURE? "Martin K. Petersen" <martin.petersen@oracle.com> - 2017-03-28 03:50 +0200
    Re: scsi_debug: shared dev context, BUG or FEATURE? Dmitry Monakhov <dmonakhov@openvz.org> - 2017-03-28 12:40 +0200

csiph-web