Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1609960

Re: [PATCHv2] braille-console: Fix value returned by _braille_console_setup

Show all headers | View raw

On (03/26/17 22:47), Samuel Thibault wrote:
> commit bbeddf52adc1 ("printk: move braille console support into
> separate braille.[ch] files") introduced _braille_console_setup()
> to outline the braille initialization code.  There was however some
> confusion over the value it was supposed to return. commit 2cfe6c4ac7ee
> ("printk: Fix return of braille_register_console()") tried to fix it
> but failed to.
> 
> This fixes and documents the returned value according to the use
> in printk.c: non-zero return means a parsing error, and thus this
> console configuration should be ignored.

I just found this patch in my gmail "spam" folder.

sorry.


the patch looks OK to me.

btw, is there any reason why _braille_console_setup() and
_braille_register_console()/_braille_unregister_console()
names start with a dash? do we also want to "clean this up"?
well since we are at it.

	-ss

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCHv2] braille-console: Fix value returned by  _braille_console_setup Samuel Thibault <samuel.thibault@ens-lyon.org> - 2017-03-26 23:00 +0200
  Re: [PATCHv2] braille-console: Fix value returned by  _braille_console_setup Sergey Senozhatsky <sergey.senozhatsky@gmail.com> - 2017-03-27 17:50 +0200

csiph-web