Re: [PATCH v7 5/9] media: venus: vdec: add video decoder files

From	Nicolas Dufresne <nicolas@ndufresne.ca>
Newsgroups	linux.kernel
Subject	Re: [PATCH v7 5/9] media: venus: vdec: add video decoder files
Date	2017-03-27 17:10 +0200
Message-ID	<tpErq-1wA-59@gated-at.bofh.it> (permalink)
References	<tkBaN-3bi-5@gated-at.bofh.it> <tkBaO-3bi-19@gated-at.bofh.it> <toyHp-2WH-31@gated-at.bofh.it> <tp2Fr-7mu-17@gated-at.bofh.it> <tpyvD-5he-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Le lundi 27 mars 2017 à 10:45 +0200, Hans Verkuil a écrit :
> > > timestamp and sequence are only set for CAPTURE, not OUTPUT. Is
> > > that correct?
> > 
> > Correct. I can add sequence for the OUTPUT queue too, but I have no
> > idea how that sequence is used by userspace.
> 
> You set V4L2_BUF_FLAG_TIMESTAMP_COPY, so you have to copy the
> timestamp from the output buffer
> to the capture buffer, if that makes sense for this codec. If not,
> then you shouldn't use that
> V4L2_BUF_FLAG and just generate new timestamps whenever a capture
> buffer is ready.
> 
> For sequence numbering just give the output queue its own sequence
> counter.

Btw, GStreamer and Chromium only supports TIMESTAMP_COPY, and will most
likely leak frames if you craft timestamp.

Nicolas

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v7 5/9] media: venus: vdec: add video decoder files Hans Verkuil <hverkuil@xs4all.nl> - 2017-03-24 15:50 +0100
  Re: [PATCH v7 5/9] media: venus: vdec: add video decoder files Nicolas Dufresne <nicolas@ndufresne.ca> - 2017-03-24 19:30 +0100
    Re: [PATCH v7 5/9] media: venus: vdec: add video decoder files Stanimir Varbanov <stanimir.varbanov@linaro.org> - 2017-03-26 00:20 +0100
  Re: [PATCH v7 5/9] media: venus: vdec: add video decoder files Stanimir Varbanov <stanimir.varbanov@linaro.org> - 2017-03-25 23:50 +0100
    Re: [PATCH v7 5/9] media: venus: vdec: add video decoder files Nicolas Dufresne <nicolas@ndufresne.ca> - 2017-03-27 04:30 +0200
      Re: [PATCH v7 5/9] media: venus: vdec: add video decoder files Hans Verkuil <hverkuil@xs4all.nl> - 2017-03-27 11:00 +0200
    Re: [PATCH v7 5/9] media: venus: vdec: add video decoder files Hans Verkuil <hverkuil@xs4all.nl> - 2017-03-27 10:50 +0200
    Re: [PATCH v7 5/9] media: venus: vdec: add video decoder files Hans Verkuil <hverkuil@xs4all.nl> - 2017-03-27 10:50 +0200
      Re: [PATCH v7 5/9] media: venus: vdec: add video decoder files Stanimir Varbanov <stanimir.varbanov@linaro.org> - 2017-03-27 14:00 +0200
      Re: [PATCH v7 5/9] media: venus: vdec: add video decoder files Nicolas Dufresne <nicolas@ndufresne.ca> - 2017-03-27 17:10 +0200

csiph-web