Re: [RFC v5 9/9] sched/deadline: also reclaim bandwidth not used by dl tasks

Path	csiph.com!xmission!news.glorb.com!diesel.cu.mi.it!bofh.it!news.nic.it!robomod
From	Luca Abeni <luca.abeni@santannapisa.it>
Newsgroups	linux.kernel
Subject	Re: [RFC v5 9/9] sched/deadline: also reclaim bandwidth not used by dl tasks
Date	Mon, 27 Mar 2017 17:00:02 +0200
Message-ID	<tpEhI-17e-29@gated-at.bofh.it> (permalink)
References	<toh3P-72e-5@gated-at.bofh.it> <toh3P-72e-11@gated-at.bofh.it> <tpDvk-Li-5@gated-at.bofh.it>
X-Original-To	Peter Zijlstra <peterz@infradead.org>
X-Mailer	Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu)
MIME-Version	1.0
Content-Type	text/plain; charset=US-ASCII
Content-Transfer-Encoding	7bit
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	42
Organization	linux.* mail to news gateway
X-Original-Cc	linux-kernel@vger.kernel.org, Ingo Molnar <mingo@redhat.com>, Juri Lelli <juri.lelli@arm.com>, Claudio Scordino <claudio@evidence.eu.com>, Steven Rostedt <rostedt@goodmis.org>, Tommaso Cucinotta <tommaso.cucinotta@sssup.it>, Daniel Bristot de Oliveira <bristot@redhat.com>, Joel Fernandes <joelaf@google.com>, Mathieu Poirier <mathieu.poirier@linaro.org>
X-Original-Date	Mon, 27 Mar 2017 16:48:48 +0200
X-Original-Message-ID	<20170327164848.510bf8c7@luca>
X-Original-References	<1490327582-4376-1-git-send-email-luca.abeni@santannapisa.it> <1490327582-4376-10-git-send-email-luca.abeni@santannapisa.it> <20170327140341.yvjjr6hbow2jug3t@hirez.programming.kicks-ass.net>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1609910

Show key headers only | View raw

Hi Peter,

On Mon, 27 Mar 2017 16:03:41 +0200
Peter Zijlstra <peterz@infradead.org> wrote:

> On Fri, Mar 24, 2017 at 04:53:02AM +0100, luca abeni wrote:
> 
> > +static inline
> > +void __dl_update(struct dl_bw *dl_b, s64 bw)
> > +{
> > +	struct root_domain *rd = container_of(dl_b, struct
> > root_domain, dl_bw);
> > +	int i;
> > +
> > +	RCU_LOCKDEP_WARN(!rcu_read_lock_sched_held(),
> > +			 "sched RCU must be held");
> > +	for_each_cpu_and(i, rd->span, cpu_active_mask) {
> > +		struct rq *rq = cpu_rq(i);
> > +
> > +		rq->dl.extra_bw += bw;
> > +	}  
> 
> So this is unfortunate (and we already have one such instance).
> 
> It effectively does an for_each_online_cpu() with IRQs disabled, and
> on SGI class hardware that takes _forever_.

I have to admit I copied this code from somewhere else... :)

I am happy to discuss a better solution.


			Thanks,
				Luca

> 
> This is also what I got stuck on trying to rewrite AC to use Tommaso's
> recoverable thing. In the end I had to do a 2 stage try/commit
> variant. Which ended up being a pain and I didn't finish.
> 
> I'm not saying this patch is bad, but this is something we need to
> thing about.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[RFC v5 9/9] sched/deadline: also reclaim bandwidth not used by dl tasks luca abeni <luca.abeni@santannapisa.it> - 2017-03-23 21:00 +0100
  Re: [RFC v5 9/9] sched/deadline: also reclaim bandwidth not used by  dl tasks Peter Zijlstra <peterz@infradead.org> - 2017-03-27 16:10 +0200
    Re: [RFC v5 9/9] sched/deadline: also reclaim bandwidth not used by  dl tasks Luca Abeni <luca.abeni@santannapisa.it> - 2017-03-27 17:00 +0200

csiph-web