Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1609862

Re: [PATCH 0/4] sched: Minor cleanups

Show all headers | View raw

On Thu, Mar 23, 2017 at 05:05:55PM +0530, Viresh Kumar wrote:
> Hi,
> 
> Here are few minor cleanups for the sched core. The first three tries to
> avoid reinitializing memory which is already set to zero and the last
> one drops an unused statement.
> 

I'm OK with the kzalloc/memset thing, but I'd prefer to keep all those
other bits.

Yes they're superfluous, but this is init code, so nobody cares about
performance and having those things explitic makes it easier to read.

As to the very latest patch, that's there so that if/when we extend that
array we can simply continue. Also its more symmetric/consistent. Any
half sane DCE pass should get rid of it anyway, as the result is unused.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/4] sched: Minor cleanups Viresh Kumar <viresh.kumar@linaro.org> - 2017-03-23 12:40 +0100
  [PATCH 1/4] sched: topology: drop memset() from init_rootdomain() Viresh Kumar <viresh.kumar@linaro.org> - 2017-03-23 12:40 +0100
  [PATCH 4/4] sched: core: drop useless expression from sched_init() Viresh Kumar <viresh.kumar@linaro.org> - 2017-03-23 12:40 +0100
  [PATCH 3/4] sched: cpupri: don't re-initialize struct cpupri Viresh Kumar <viresh.kumar@linaro.org> - 2017-03-23 12:40 +0100
  Re: [PATCH 0/4] sched: Minor cleanups Peter Zijlstra <peterz@infradead.org> - 2017-03-27 16:00 +0200
    Re: [PATCH 0/4] sched: Minor cleanups Viresh Kumar <viresh.kumar@linaro.org> - 2017-04-10 11:40 +0200

csiph-web