Re: [PATCH v11 11/12] iio: multiplexer: fix unsigned check with less than zero

From	Johan Hovold <johan@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v11 11/12] iio: multiplexer: fix unsigned check with less than zero
Date	2017-03-27 15:10 +0200
Message-ID	<tpCzg-8vt-39@gated-at.bofh.it> (permalink)
References	<tpCzg-8vt-41@gated-at.bofh.it> <tpCzg-8vt-43@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Mar 27, 2017 at 02:17:48PM +0200, Peter Rosin wrote:
> Comparing a size_t with less than zero is always false as size_t
> is unsigned. So, change the type of the variable to ssize_t and
> replicate the size check from mux_configure_channel() into
> mux_write_ext_info() thus ensuring that the size will fit in the
> ssize_t variable.
> 
> Detected by CoverityScan, CID#1415278 ("Unsigned compared against 0")
> 
> Fixes: 1da8e16d2812 ("iio: multiplexer: new iio category and iio-mux driver")

You should fold this one and the next patch into the patches that they
fix up instead fixing stuff that's not yet merged incrementally like you
do here (specifically, the SHA id above will have no matching commit).

Johan

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v11 11/12] iio: multiplexer: fix unsigned check with less  than zero Johan Hovold <johan@kernel.org> - 2017-03-27 15:10 +0200
  Re: [PATCH v11 11/12] iio: multiplexer: fix unsigned check with less  than zero Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-03-27 16:10 +0200
  Re: [PATCH v11 11/12] iio: multiplexer: fix unsigned check with less  than zero Johan Hovold <johan@kernel.org> - 2017-03-27 16:40 +0200

csiph-web