Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1609830

[PATCH v3 6/9] drivers: remove useless comment from base/arch_topology.c

Show all headers | View raw

Printing out an error message when we failed to get the cpu device is
not helping anyone. Remove it.

Signed-off-by: Juri Lelli <juri.lelli@arm.com>
---
 drivers/base/arch_topology.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/base/arch_topology.c b/drivers/base/arch_topology.c
index c33482121b7d..b24d9a2af2c5 100644
--- a/drivers/base/arch_topology.c
+++ b/drivers/base/arch_topology.c
@@ -81,11 +81,9 @@ static int register_cpu_capacity_sysctl(void)
 
 	for_each_possible_cpu(i) {
 		cpu = get_cpu_device(i);
-		if (!cpu) {
-			pr_err("%s: too early to get CPU%d device!\n",
-			       __func__, i);
+		if (!cpu)
 			continue;
-		}
+
 		device_create_file(cpu, &dev_attr_cpu_capacity);
 	}
 
-- 
2.10.0

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 0/9] Fix issues and factorize arm/arm64 capacity information code Juri Lelli <juri.lelli@arm.com> - 2017-03-27 15:20 +0200
  [PATCH v3 7/9] arm,arm64,drivers: reduce scope of cap_parsing_failed Juri Lelli <juri.lelli@arm.com> - 2017-03-27 15:20 +0200
    Re: [PATCH v3 7/9] arm,arm64,drivers: reduce scope of  cap_parsing_failed Catalin Marinas <catalin.marinas@arm.com> - 2017-04-10 10:40 +0200
  [PATCH v3 3/9] arm: fix return value of parse_cpu_capacity Juri Lelli <juri.lelli@arm.com> - 2017-03-27 15:20 +0200
    Re: [PATCH v3 3/9] arm: fix return value of parse_cpu_capacity Vincent Guittot <vincent.guittot@linaro.org> - 2017-03-29 09:40 +0200
      Re: [PATCH v3 3/9] arm: fix return value of parse_cpu_capacity Juri Lelli <juri.lelli@arm.com> - 2017-03-29 10:10 +0200
  [PATCH v3 2/9] Documentation/ABI: add information about cpu_capacity Juri Lelli <juri.lelli@arm.com> - 2017-03-27 15:20 +0200
  [PATCH v3 6/9] drivers: remove useless comment from base/arch_topology.c Juri Lelli <juri.lelli@arm.com> - 2017-03-27 15:30 +0200
    Re: [PATCH v3 6/9] drivers: remove useless comment from  base/arch_topology.c Russell King - ARM Linux <linux@armlinux.org.uk> - 2017-04-10 16:00 +0200
      Re: [PATCH v3 6/9] drivers: remove useless comment from  base/arch_topology.c Juri Lelli <juri.lelli@arm.com> - 2017-04-10 16:10 +0200
  [PATCH v3 9/9] arm,arm64,drivers: add a prefix to drivers arch_topology interfaces Juri Lelli <juri.lelli@arm.com> - 2017-03-27 15:30 +0200
    Re: [PATCH v3 9/9] arm, arm64, drivers: add a prefix to drivers  arch_topology interfaces Catalin Marinas <catalin.marinas@arm.com> - 2017-04-10 10:40 +0200
  [PATCH v3 5/9] arm, arm64: factorize common cpu capacity default code Juri Lelli <juri.lelli@arm.com> - 2017-03-27 15:50 +0200
    Re: [PATCH v3 5/9] arm, arm64: factorize common cpu capacity default  code Greg KH <gregkh@linuxfoundation.org> - 2017-04-08 18:30 +0200
    Re: [PATCH v3 5/9] arm, arm64: factorize common cpu capacity default  code Catalin Marinas <catalin.marinas@arm.com> - 2017-04-10 10:20 +0200
  [PATCH v3 8/9] arm,arm64,drivers: move externs in a new header file Juri Lelli <juri.lelli@arm.com> - 2017-03-27 15:50 +0200
    Re: [PATCH v3 8/9] arm,arm64,drivers: move externs in a new header  file Catalin Marinas <catalin.marinas@arm.com> - 2017-04-10 10:40 +0200
  Re: [PATCH v3 0/9] Fix issues and factorize arm/arm64 capacity  information code Juri Lelli <juri.lelli@arm.com> - 2017-04-06 16:20 +0200

csiph-web