Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1609751
| Path | csiph.com!1.us.feeder.erje.net!2.us.feeder.erje.net!feeder.erje.net!1.eu.feeder.erje.net!weretis.net!feeder4.news.weretis.net!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod |
|---|---|
| From | Michael Ellerman <mpe@ellerman.id.au> |
| Newsgroups | linux.kernel |
| Subject | Re: [v3 PATCH 2/4] powernv:smp: Add busy-wait loop as fall back for CPU-Hotplug |
| Date | Mon, 27 Mar 2017 13:50:02 +0200 |
| Message-ID | <tpBjQ-7ro-19@gated-at.bofh.it> (permalink) |
| References | <tnQ3F-4lf-37@gated-at.bofh.it> <tnQ3E-4lf-35@gated-at.bofh.it> |
| User-Agent | Notmuch/0.21 (https://notmuchmail.org) |
| MIME-Version | 1.0 |
| Content-Type | text/plain |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 22 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, "Gautham R. Shenoy" <ego@linux.vnet.ibm.com> |
| X-Original-Date | Mon, 27 Mar 2017 22:43:44 +1100 |
| X-Original-Message-ID | <87fuhzdjwv.fsf@concordia.ellerman.id.au> |
| X-Original-References | <cover.1490194710.git.ego@linux.vnet.ibm.com> <261607d15ec471d88a8d31ee50614c64a4018b90.1490194710.git.ego@linux.vnet.ibm.com> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1609751 |
Show key headers only | View raw
"Gautham R. Shenoy" <ego@linux.vnet.ibm.com> writes:
> diff --git a/arch/powerpc/platforms/powernv/idle.c b/arch/powerpc/platforms/powernv/idle.c
> index 419edff..f335e0f 100644
> --- a/arch/powerpc/platforms/powernv/idle.c
> +++ b/arch/powerpc/platforms/powernv/idle.c
> @@ -283,8 +283,16 @@ unsigned long pnv_cpu_offline(unsigned int cpu)
> } else if ((idle_states & OPAL_PM_SLEEP_ENABLED) ||
> (idle_states & OPAL_PM_SLEEP_ENABLED_ER1)) {
> srr1 = power7_sleep();
> - } else {
> + } else if (idle_states & OPAL_PM_NAP_ENABLED) {
> srr1 = power7_nap(1);
> + } else {
> + /* This is the fallback method. We emulate snooze */
> + while (!generic_check_cpu_restart(cpu)) {
Breaks the SMP=n build :/
arch/powerpc/platforms/powernv/idle.c:299:11: error: implicit declaration of function 'generic_check_cpu_restart' [-Werror=implicit-function-declaration]
cheers
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[v3 PATCH 2/4] powernv:smp: Add busy-wait loop as fall back for CPU-Hotplug "Gautham R. Shenoy" <ego@linux.vnet.ibm.com> - 2017-03-22 16:10 +0100
Re: [v3 PATCH 2/4] powernv:smp: Add busy-wait loop as fall back for CPU-Hotplug Michael Ellerman <mpe@ellerman.id.au> - 2017-03-27 13:50 +0200
Re: [v3 PATCH 2/4] powernv:smp: Add busy-wait loop as fall back for CPU-Hotplug Gautham R Shenoy <ego@linux.vnet.ibm.com> - 2017-03-30 11:30 +0200
csiph-web