Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1609749
| From | Johannes Berg <johannes@sipsolutions.net> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] cfg80211: Fix array-bounds warning in fragment copy |
| Date | 2017-03-27 13:40 +0200 |
| Message-ID | <tpBaa-7no-17@gated-at.bofh.it> (permalink) |
| References | <toInn-1Fh-13@gated-at.bofh.it> <tpAnL-6J9-19@gated-at.bofh.it> <tpBa9-7no-1@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
> > > - const skb_frag_t *frag = &sh->frags[-1]; > > > + const skb_frag_t *frag = &sh->frags[0]; [...] > > > + frag--; > > > > Isn't it just a question of time until the compiler will see > > through this trick and warn about it? > > Frag is incremented again before being accessed, so there is nothing > for the compiler to see through here. But by that argument the existing code was already fine. The compiler flagged it nonetheless, perhaps because it couldn't prove it was incremented unconditionally/in all branches? johannes
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] cfg80211: Fix array-bounds warning in fragment copy Matthias Kaehlcke <mka@chromium.org> - 2017-03-25 02:10 +0100
Re: [PATCH] cfg80211: Fix array-bounds warning in fragment copy Johannes Berg <johannes@sipsolutions.net> - 2017-03-27 12:50 +0200
Re: [PATCH] cfg80211: Fix array-bounds warning in fragment copy Felix Fietkau <nbd@nbd.name> - 2017-03-27 13:40 +0200
Re: [PATCH] cfg80211: Fix array-bounds warning in fragment copy Johannes Berg <johannes@sipsolutions.net> - 2017-03-27 13:40 +0200
Re: [PATCH] cfg80211: Fix array-bounds warning in fragment copy Matthias Kaehlcke <mka@chromium.org> - 2017-03-27 21:50 +0200
csiph-web