Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1609747

Re: [virtio-dev] [PATCH] virtio-blk: add DISCARD support to virtio-blk driver

From Paolo Bonzini <pbonzini@redhat.com>
Newsgroups linux.kernel
Subject Re: [virtio-dev] [PATCH] virtio-blk: add DISCARD support to virtio-blk driver
Date 2017-03-27 13:40 +0200
Message-ID <tpBaa-7no-11@gated-at.bofh.it> (permalink)
References <tpych-55m-11@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw



On 28/03/2017 10:39, Changpeng Liu wrote:
> +	if (virtio_has_feature(vdev, VIRTIO_BLK_F_DISCARD)) {
> +		q->limits.discard_zeroes_data = 0;

Maybe you could use another feature bit to populate discard_zeroes_data.

Paolo

> +		q->limits.discard_alignment = blk_size;
> +		q->limits.discard_granularity = blk_size;
> +		blk_queue_max_discard_sectors(q, UINT_MAX);
> +		blk_queue_max_discard_segments(q, 1);
> +		queue_flag_set_unlocked(QUEUE_FLAG_DISCARD, q);
> +	}
> +

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] virtio-blk: add DISCARD support to virtio-blk driver Changpeng Liu <changpeng.liu@intel.com> - 2017-03-27 10:30 +0200
  Re: [virtio-dev] [PATCH] virtio-blk: add DISCARD support to  virtio-blk driver Paolo Bonzini <pbonzini@redhat.com> - 2017-03-27 13:40 +0200
    RE: [virtio-dev] [PATCH] virtio-blk: add DISCARD support to  virtio-blk driver "Liu, Changpeng" <changpeng.liu@intel.com> - 2017-03-28 04:00 +0200
  Re: [PATCH] virtio-blk: add DISCARD support to virtio-blk driver Christoph Hellwig <hch@lst.de> - 2017-03-27 17:00 +0200
    RE: [PATCH] virtio-blk: add DISCARD support to virtio-blk driver "Liu, Changpeng" <changpeng.liu@intel.com> - 2017-03-28 03:50 +0200
  Re: [PATCH] virtio-blk: add DISCARD support to virtio-blk driver Stefan Hajnoczi <stefanha@gmail.com> - 2017-03-27 22:30 +0200
    RE: [PATCH] virtio-blk: add DISCARD support to virtio-blk driver "Liu, Changpeng" <changpeng.liu@intel.com> - 2017-03-28 04:20 +0200
      Re: [PATCH] virtio-blk: add DISCARD support to virtio-blk driver Stefan Hajnoczi <stefanha@gmail.com> - 2017-03-28 10:40 +0200

csiph-web